Git Product home page Git Product logo

bereikbaarheid-frontend's People

Contributors

sidneygijzen avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar

bereikbaarheid-frontend's Issues

bug door

Describe the bug
The code expects from the RDW API a value with the name maximum_massa_samenstelling (which does not exist anymore, at least not in all cases)

To Reproduce

  1. Go to https://kaart.nationaalwegenbestand.nl/bereikbaarheid with license plate bxls14 and height 4 meter
  2. Click on go with checkboxes unchecked
  3. See error
    image

Expected behavior
the page should show the RDW results but does not

Screenshots
I believe the problem is the following.
on the left the code expects a column in the RDW data with the name 'maximum_massa_samenstelling'
this column does not exist in the API (anymore) so it seems.
It used to be there and return a value.
This is the url of the API of RDW https://opendata.rdw.nl/api/id/m9d7-ebf2.json?kenteken=BXLS14
image

So the bug is i believe on this page https://github.com/GemeenteUtrecht/bereikbaarheid-frontend/blob/main/src/api/rdw/vehicle/index.ts

Additional context
The relevance of this value, if I remember correctly, is to check whether or not the vehicle weight together with the weight of the load should be lower then maximum_massa_samenstelling . If this value does not exist the code breaks. As a quick fix the maximum value could be hard coded as 60000 kg. Later it can replaced in a better way.

Also on the RDW webpage https://ovi.rdw.nl/ the value is 0 (problaby not existing and then defaulting to 0 )
image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.