gelio / cmp-natdat Goto Github PK

Resolving the time-only completion (e.g. @7:25) should include the current date: 2023-10-26 7:25.

Otherwise, the @7:25 completion is useless, since it is the same as just typing the time 7:25.

Let's refactor the way formatting is done to allow users to plug in their own formatters if they do not like the default formatting.

This would involve:

1. Creating a natdat.Formatter type with methods for formatting different structs

   ---@class natdat.Formatter
   ---@field format_month fun(month: natdat.Month): string
   ---@field format_absolute_date fun(absolute_date: natdat.AbsoluteDate): string
   ---...

2. Creating 2 formatters:

   • ISOFormatter with methods from existing format_iso
   • LabelFormatter with methods from existing format_original

3. Replacing the format_iso and format_original methods on structures with a single format fun(formatter: natdat.Formatter): string. Each such method would call a corresponding formatter method.

4. Accepting a formatter for the insertText in the cmp_natdat source. By default, it would be the ISOFormatter

Could you consider setting up a custom kind for this source, so that it's possible to customize its icon? Copilot cmp does it and it lets me modify the Copilot icon like so:

{
	-- Vscode-like pictograms for Neovim LSP completion items.
	"onsails/lspkind.nvim",
	config = function()
		local lspkind = require("lspkind")
		lspkind.init({
			symbol_map = {
				-- This is an Octocat with devicons.
				Copilot = "",
			},
		})
		vim.api.nvim_set_hl(0, "CmpItemKindCopilot", { fg = "#6CC644" })
	end,
	lazy = true,
}

Sometimes the colon is unnecessary when resolving the time.

• 725 -> 7:25
• 1420 -> 14:20
• 5 -> 5:00

Let's modify the time parser to account for these situations.

Sometimes this could lead to ambiguities:

• Oct 2 725 -> 725-10-2 (just the date) or 2023-10-02 7:25

I believe we should only make the colon optional when the format expects a time, so:

• after a relative date
• after a day of the week
• at the beginning of the query