It looks like with newer versions of OS X (I'm on Mojave, 10.14.6) the desktop background you've got in the script no longer exists. When you run the line to update the background the Dock gets stuck in a loop where it's constantly crashing with an error that looks very similar to this one:

2018-08-18 22:05:31.276 Dock[1061:44244] -[__NSCFNumber stringByExpandingTildeInPath]: unrecognized selector sent to instance 0xe5cdf6a4f4b8bcfb
2018-08-18 22:05:31.277 Dock[1061:44244] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFNumber stringByExpandingTildeInPath]: unrecognized selector sent to instance 0xe5cdf6a4f4b8bcfb

# michael @ xanadu in ~ [11:20:53]
$ ls /Library/Desktop\ Pictures/Solid\ Colors
 Black.png         'Dusty Rose.png'      Gold.png   'Red Orange.png'  'Soft Pink.png'        Stone.png              Yellow.png
'Blue Violet.png'  'Electric Blue.png'   Ocher.png  'Rose Gold.png'   'Space Gray Pro.png'   Teal.png
 Cyan.png          'Gold 2.png'          Plum.png    Silver.png       'Space Gray.png'      'Turquoise Green.png'

Often this command is run inside a Terminal session or in a way in which the restart of Finder, Dock, Terminal, Mail, UIServer, etc. can be quite jarring... especially when run as part of an automated process.

So I'd like to add a --no-restart flag to allow the script to run without restarting any services or open applications.

Right now, this script always prompts for/requires sudo privileges, which can make automated runs annoying if not (sometimes) impossible. I'd like to make the commands requiring sudo optional, and only perform sudo-related stuff if the script is run with sudo/as root.

I'll still warn if not run with sudo, but most everything can be configured without sudo anyways.

🙃

# disable in-app ratings & review requests from apps downloaded from appstore
defaults write com.apple.appstore InAppReviewEnabled -int 0

Hi @geerlingguy, was using your PS1 variable for my prompt on macOS High Sierra via iTerm and having no issues but recently I upgraded Bash to version 5.0 using Homebrew and discovered issues with my prompt. If I typed a command that extended to the far right end of the line, additional characters were placed at the start of the same line, overwriting the line rather than jumping to the next one. By making some tweaks to your PS1 variable I was able to resolve that issue. Here is what I came up with:

export PS1="\[\e[0;32m\] \[\e[1;32m\]\t \[\e[0;2m\]\w \[\e[0m\]\$ "

I noticed you had an extraneous \] sequence after each color code (in addition to the correct escape wrapper). Also the  and $ were unnecessarily marked as non-printable characters, which caused my ctrl-a presses to move the cursor back onto the $ rather than two positions after it.

Not sure why the bug wasn't showing up with the default Bash install but you can try to reproduce the issue by installing a different version of Bash.

Hi! Your dotfiles look awesome, what are these licensed under? Could you add it to the repo?

Thank you very much!