reorganize javascript in index.php about raspberry-pi-heartbeat HOT 6 CLOSED

I will do this tomorrow !

from raspberry-pi-heartbeat.

I don't think we can put the JS in a .js file since we are using our PHP functions to fill out the javascript arrays... I'll mark it closed because I don't think it can be made. Now index.php is much more clean, so I don't think the inline JS is that big of a problem.

from raspberry-pi-heartbeat.

but can we wrap the graph stuff into functions, with php insert arrays into javascript as vars and call for function passing that var....)). ?

but it might be not worth it:)

from raspberry-pi-heartbeat.

I don't think you can since .js files are loaded by the browser, not the server, so you can't inject PHP arrays there.

from raspberry-pi-heartbeat.

Wont ia work like that:

So the js file has a function and php inserts the var and the call for that
function. Though the order should be different, first load the js file then
goes the var and the call i guess)

Cant try that myself now. Only by the end of this week.
On Jun 29, 2013 5:52 PM, "Daniel Parreira" [email protected] wrote:

I don't think you can since .js files are loaded by the browser, not the
server, so you can't inject PHP arrays there.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-20232139
.

from raspberry-pi-heartbeat.

Yes, but that way the JS code has to be in the same .php file or another PHP file: not very clean IMHO ;)

from raspberry-pi-heartbeat.