Git Product home page Git Product logo

msslib's Issues

getCol with maxCloudCover set to 0 returns images with CLOUD_COVER greater than 0

Reproducible example: https://code.earthengine.google.com/0060c69c481eb30ecce9d51c1c23580d

I think the issue comes from here, where because 0 evaluates as false it gets replaced by the default parameter of 50:

msslib/msslib.js

Lines 374 to 379 in e1e59cf

// Replace default params with provided params.
if (params) {
for (var param in params) {
_params[param] = params[param] || _params[param];
}
}

Checking if the provided params are null or undefined has all the same behaviour as the current method, but allows maxCloudCover to be set to 0. For example:

// Replace default params with provided params.
  if (params) {
    for (var param in params) {
      if (params[param] != null) {
        _params[param] = params[param];
      }
    }
  }

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.