Git Product home page Git Product logo

bootstrap4-dialog's People

Contributors

afro1114 avatar andreweastwood avatar avan06 avatar bitclaw avatar breity avatar codepiano avatar cvrebert avatar danielentryless avatar dmitri-sintsov avatar eugenmayer avatar fabn avatar gedmarc avatar hpatoio avatar indrimuska avatar javierrgz avatar jbolila avatar jogibear9988 avatar julusian avatar jzeyer avatar levacic avatar michael-maltsev avatar nakupanda avatar pseudoninja avatar tangqian avatar tisie avatar wladiz2001 avatar yohn avatar zohaibms avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bootstrap4-dialog's Issues

Get Some html constructions error with bootsrap 4.3

Hi !,
Nice work with bootstrap 4 but I got some construction error with bootstrap 4.3. Error are in the header and in the footer where class have changed.

I will try to change this in a fork and create a pull request.

Error in determining version

bootstrap4-dialog-error

I'm getting an error I can't resolve pictured in the attached image. The error is in line 55.

I'm using BootStrap 5.1.0. I have tried other versions including rolling back to 4.x with no joy. Could you help me?

Thanks!

Pat

bootstrap-dialog-close-button not right aligned in dialog

image

Description:
As described. (See screenshot above)

Solved by adding this in CSS:
.bootstrap-dialog-header { width: 100%; }

image

Probable cause:
bootstrap-dialog-header width was equal to its content width.
After changing the bootstrap-dialog-header width to 100%, bootstrap-dialog-close-button was able to right align to the end of the header.

e.querySelector is not a function

I encountered the follow error while using BootstrapDialog.confirm() with Bootstrap 4.1.3:

Uncaught TypeError: e.querySelector is not a function

Tracing down the changes between boostrap 4.0 and 4.1.3 I got the following:

bildschirmfoto 2018-11-22 um 11 55 52

in bootstrap/js/src/modal.js in the current 4.1.3 package.

Colours sugestion

Hi.
great job but in src/scss/bootstrap-dialog.scss should be variables of colours not static numbers like:

.bootstrap-dialog.type-primary .modal-header {
background-color: $primary;
}

Bootstrap 5.2.3/5.3.2 Support

Are you planning to support newer versions of Bootstrap. Using the latest version of Bootstrap-Dialog, v4.4.4, I am unable to open an instance of the dialog anymore.

Using the following basic code example with either Bootstrap v5.2.3 or v5.3.2, I get the error further below:

Code Example
BootstrapDialog.show({
size: BootstrapDialog.SIZE_WIDE,
title: "Loading Customer Request",
message: <br/>Customer Request search page is being loaded. Please wait . . .,
type: "type-info",
closeByBackdrop: false,
closeByKeyboard: false,
closable: true,
draggable: true,
})

Console Error
bootstrap-dialog.min.js:1 Uncaught TypeError: Class constructor On cannot be invoked without 'new'
at new BootstrapDialogModal (bootstrap-dialog.min.js:1:695)
at BootstrapDialog.realize (bootstrap-dialog.min.js:1:25348)
at BootstrapDialog.open (bootstrap-dialog.min.js:1:8047)
at BootstrapDialog.show (bootstrap-dialog.min.js:1:26338)
at CustomerLanding.aspx:1125:29
at dispatch (jquery.min.js:2:43090)
at v.handle (jquery.min.js:2:41074)

Loading as ES6 Module not possible

Hello,

I wanted to load as ES6 Module in the Browser like this:

import '/node_modules/bootstrap4-dialog/dist/js/bootstrap-dialog.js';

but it is not possible, root is undefined in
bootstrap-dialog.js line 29

I think it is because "this" is not window when you use es6 modules

close all open modal

thanks for your work on updating the plugin!!
I only have the problem, which I do not achieve. close all open modal.

 $.each(BootstrapDialog.dialogs, function(id, dialog){
                    dialog.close();
  });

How is this achieved? in advance thank you very much and apologize for the bad english :P

On load remote page, not execute javascript

Hi,

We are loading the modal's content using:

message: $('<div></div>').load('Sapp?/crmcustomer.newcrminput');

In load page, to try it, we have a simple javascript code like this one :
`

<script type="text/javascript"> alert('inidlg'); </script>

`

When we execute "BootstrapDialog.show" the dialog appears but this simple javascript doesn't work.

Thanks for this amazing tool.

README install instructions still name bootstrap3-dialog

Hey, mainly wanted to create an issue to thank you for the package @GedMarc. Seems to be working as a drop-in replacement for bootstrap3-dialog after upgrading bootstrap4.

However, README still mentions the old package, and also your listing in bower has the wrong repo link:

image

setCloseByBackdrop not work

Hi.
Cannot prevent modal close by backdrop click after modal shown.

Methods:
setCloseByBackdrop(false);
setCloseByKeyboard(false);

not works.

Method:
setClosable(false);

only remove "x" sign. Backdrop click still active.

http://jsfiddle.net/tpy5eogs/

Can you help me?

Not working with bootstrap 5

I have used this library this is working with bootstrap 4 but when I use bootstrap 5 it shows below console error on page load and also when popup button is clicked. Popup does not open.

image

In the code sample when bootstrap 5 CDN is used instead of 4 then there also popup is not visible.
http://jsfiddle.net/qu6r3shn/

btn-default style no longer exists in bootstrap 4.2.1

Since btn-default no longer exists as a style (at least it doesn't show a button ...), the button shows up as text only.

Line 907 of bootstrap-dialog.js

Fix: add custom css or change to btn-secondary, btn-dark etc

outdated npm

Hello, I am trying to work with bootstrap version 5.1.3 through NPM but I see that the latest version is not on par with this one, could you update it please.
sorry to bother about the same thing every year #33

Close icon on right side

The close Icon is behind the title text (see also yr examples).
But it should be right aligned. To make this work i needed:

.bootstrap-dialog-header {
width: 100%;
}

Compatibility with Bootstrap 4.3.*

Hello, I have a console error and the dialog doesn't shows with Bootstrap 4.3.1

Uncaught TypeError: Cannot set property 'scrollTop' of null

Do you find it ?
Thanks

bye bye jquery

at some point will we stop using jQuery? I would like to integrate the library with svelte or react without including jQuery

Bootstrap 5.2

With Bootstrap 5.2 the modal has some alignment issue, i think it is because the HTML/classes for the modal changed in the latest version.

See attachment
image

sass for bootstrap theme colors

sass
.bootstrap-dialog {
@each $color, $value in $theme-colors {
&.type-#{$color} {
.modal-header {
background-color: $value;
}
}
}

.bootstrap-dialog-header{
    flex: auto;
    .bootstrap-dialog-title {
        color: #fff;
        font-size: 16px;
    }

    .bootstrap-dialog-close-button {
        float: right;
    }

    .bootstrap-dialog-close-button button {
        opacity: 0.9;
        &:hover {
            color: #fff;
            opacity: 1;
        }            
    }
}

}

NPM releases

Hi,

The latest version on NPM is 4.1.0. Is it possible to update to the latest?

Otherwise, is there somewhere else I should point my package manifest to receive updates (preferably actual releases, rather than just master branch)?

Buttons in SIZE_WIDE are pushed to new lines

bootstrap-dialog.js
line 232

//btn block makes buttons display: 'block'
BootstrapDialog.BUTTON_SIZES[BootstrapDialog.SIZE_WIDE] = 'btn-block';

What is the intended behavior here? Also, there is no class added to SIZE_EXTRAWIDE.

I suggest not basing the button sizes on the modal width, at least by default, since it is already possible to pass classes if you create the buttons manually.

Let me know if you want an example (although i can't do a jsfiddle until you update npm).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.