geckoboard / cake-bot Goto Github PK
View Code? Open in Web Editor NEWBot that manages our code review process
Bot that manages our code review process
Seems to only label PRs after a comment has been made on the pr.
Hey guys,
Great work on the bot! ๐ ๐ ๐ฐ
I'm in the process of creating a GitHub App when I came across this bot.
While reading the codebase, I noticed that we are not validating whether the webhook request received by the bot is actually triggered by a GitHub WebHook or not. This could lead to a minor security issue if one could find the payload URL and send custom POST
requests to the /github
endpoint. Setting a webhook secret
(in the bot's configuration) allows us to ensure that POST
requests sent to the payload URL are from GitHub.
Given that the bot no longer uses go-github
, we would have to write our own HMAC authenticator for validating the incoming request. As the guide suggests, we would also require a new environment variable (let's call it GITHUB_SECRET
) to be set, possibly in main.go.
Just let me know if you consider this to be useful, and I would be happy to add the functionality and contribute to the cake-bot
. ๐
Refer: Securing your webhooks
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.