gear-foundation / dapps Goto Github PK

          [![Contracts CI](https://github.com/gear-foundation/dapps/actions/workflows/contracts.yml/badge.svg?branch=master)](https://github.com/gear-foundation/dapps/actions/workflows/contracts.yml)

Originally posted by @Madib036 in #205 (comment)

Currently, tests take up an enormous amount of time of the CI workflow. On average, from 2 hours of the workflow they consume almost 3/4 of this time. The reason, initially, all tests were written for executing in separated repositories where, individually, tests didn't take up a lot of time but now, in a single workspace, this has become very critical. Therefore, we need to somehow reduce the time for tests.

Here are some ideas:

1. Analyze, rewrite & reduce the number of tests up to the most necessary
   The most time consuming tests use gclient. Some of them didn't need it all, and can be rewritten with gtest. Also, some tests are implemented for high load testing and as well take a long time. They can be moved to a separate manually controlled CI workflow or can be simply ignored by the main workflow.
2. Use a custom node binary optimized for a faster execution
   Right now we use the node binary from the official builds. By default, it's using a configuration close to one on the public net. Perhaps there can be some flags or we can modify node's internals to speed it up. Of course, security consideration must be taken to make sure that the custom node won't suppress any bugs that later may be found in the default node.
3. Put all tests for into one file in each workspace member
   This'll degrade readability but may reduce the execution time because tests in one file are executed in parallel.

Problem

our repo is currently super big even downloading with --depth=1

git clone https://github.com/gear-foundation/dapps.git --depth=1
cd dapps
du -sh .
142M

# go to the frontend folder
du -h -d1
2.6M	./.yarn
120K	./packages
 22M	./dev
 64M	./apps
 89M	.

I found that we are currently using local pictures in frontend examples, for example

https://github.com/gear-foundation/dapps/tree/master/frontend/apps/escrow/src/assets/images/icons

Solution

these icons could be replaced https://fontawesome.com/ which could be embedded in node_modules but not the git history

Problem

ref #143 , the wasm files are big as well, for example https://github.com/gear-foundation/dapps/tree/master/frontend/apps/escrow/src/assets/wasm, plus the wasm files are changing while the development of contracts, so a compile script before dev makes sense tbh

Solution

provide a script in package.json like compile to compile the target contract and cp the meta.wasm to the expected place on development

Playing around with the tamagotchi contract and app. Once the tamagotchi stat gets to 8 or below I start getting this error and the whole apps locks up. However if the stat is above 8 then the wallet transaction processes like normal.

8000: Runtime error: "Program terminated with a trap: 'attempt to subtract with overflow', /home/mikenike/dapps/contracts/tamagotchi/src/lib.rs:51:24"