gc / citizens Goto Github PK

Hey, I saw your reddit post about this project, and was wondering if there are any areas of the project where you're open for contributions. Excited to see where this leads :)

We get "remarks": [""], instead of "remarks": [],

After fixing, we should also check others for the empty remarks.

Currently, we are maintaining two separate lists of two different entity types. We should consolidate all of them into a single entity list within the region class and have that be the centralized fetch location for all the other classes. This would eliminate the potential of mismatched lists and the subsequent bugs that may be caused by that happening.

Set a scale for a scenery, save it, no scale gets set.

To make walking/movement look natural and not weird as it does now:
Pathfinding logic from https://github.com/Mrnice98/Companion-Pets-Plugin/blob/master/src/main/java/com/example/PathingLogic.java
Change our moveTo method to be like the one in this plugin too^
Ensure wanderingcitizens cannot walk through/on obstacles

Use the developermode boolean to only show certain things when developing

Scripted citizens are not handled properly in loadScriptedCitizen (and in the panel probably).

We can JSONify their actions something like this (We can discuss the format):

"script":[
   {
      "type":"MoveTo",
      "data":{
         "location":{
            "x",
            "y",
            "z"
         }
      },
      {
         "type":"Wait",
         "data":{
            "seconds":1.5
         }
      },
      {
         "type":"Say",
         "data":{
            "message":"Hi!"
         }
      }
   ]

i dont particularly think we should try to make an ingame editor for the scripts, atleast not now. it would be more complex than the others by far i think. so we can manually create them in json, which isnt too bad.

Since the Updated entity is technically a new object, it makes sense. A simple fix would be to return the new entity object then set that to the selected entity.

When creating a stationary citizen, moveAnimation gets added to the json. This ideally would cause a validation error in the json itself, I'd rather we throw a big scary error if anything in the json is even remotely slightly off like this, so we can have full confidence in our data.

Instead of having 'extra objects' per citizen, lets just use scenery instead?

Objects clip when over 1 tile in size. Fix is in setting radius. Will have to be stored in the json so we can rlObject.setRadius

Turn the plugin on/off repeatedly many times

Most, if not all, NPCs' remarks in Runescape don't appear in public chat. We should mimic this behavior.

Possibly also throw an error if the input bounding box is only 1x1 in size.