gbv / app-paia Goto Github PK

To catch errors

The response of PAIA core items is not printed to STDOUT.

the app should exit with a non-zero exit code if a PAIA command did not finish with success.

See the full documentation at https://wiki.debian.org/Teams/DebianPerlGroup and http://pkg-perl.alioth.debian.org/git.html

Maybe dh-dist-zilla can also be of use.

Is this intended? Which values should be more important? Documentation may better describe this. At least command line arguments should have precedence over session file options.

Changing a base/core/auth URL does not work if a session file exists because the URL is taken from the session file.

See http://gbv.github.io/paia/paia.html#revision-history for changes of PAIA specification.

The client should provide a global option to select a PAIA specification e.g. --spec 1.2 to use application/x-www-form-urlencoded for PAIA auth.

Subtest output is not properly intended:

     # Subtest: Erster Nutzer
# paia login -u xxx -p yyy
# paia patron
    ok 1 - patron status 2: inactive because account expired
    1..1
ok 1 - Erster Nutzer

should be

    # Subtest: Dritter Nutzer
    # paia login -u xxx -p yyy
    # paia patron
    ok 1 - patron status 2: inactive because account expired
    1..1
ok 1 - Erster Nutzer

This may die if stdout_json returns null:

PAIA "patron";
is stdout_json->{status}, 0, "Benutzer ist nicht gesperrt";
PAIA "items";
ok !error, "Benutzer kann sein Konto ansehen";
ok stdout_json->{doc}->{item}, "Benutzerkonto hat mindestesist ein Exemplar";
done_paia_test;

better:

PAIA "patron";
is stdout_json('status'), 0, "Benutzer ist nicht gesperrt";
PAIA "items";
ok !error, "Benutzer kann sein Konto ansehen";
ok stdout_json("doc.item"), "Benutzerkonto hat mindestens ein Exemplar";
done_paia_test;

maybe -a, enabled by default.

Right now this does not work as expected because the second call uses the first session:

paia login -u user1 -p xyz
paia patron -u user2 -p xyz

expected result should be same as

paia login -u user1 -p xyz
paia login -u user2 -p xyz
paia patron

The manifying process fails with the latest Pod-Simple (3.28). I think this is due to double "=encoding" directives in the .pm files. See also https://rt.cpan.org/Ticket/Display.html?id=91757

Probably it's best to remove the duplicate =encoding directives.

Regards, Slaven