gavalian / groot Goto Github PK

Hello,

Is any way to change the color scale of H2F ?

How to save an histogram on a file, and reopened it inside a different code?

If this is supposed to be the "official" repository for the groot, used by the clas12-offline-software, it should be moved over to the jeffersonlab github so it can be worked on by everyone.

The TGCanvas has a button labeled "Save All" to save all the canvas tabs in the window, but it doesn't seem to actually save any of the canvases when you click on it.

I've noticed that my H1F and GraphErrors titles do not show up in an EmbeddedCanvas.

• Add axis hide and show to GUI
• Add axis hide and show to API

leads to increasing numbers of overlapping data sets in monitoring/calibration suites where the automatic refresh of EmbeddedCanvas is used

X axis labels are cut on the right page margin. Options GUI doesn't allow setting the page margins.

• Add different marker styles (Square, diamond, etc.)
• Fill style
• Marker size

Request by @forcar

Feature requested by Cole

It would be useful to have H1F parameters such as number of entries, overflows and underflows saved when histograms are saved to a file

Cannot easily convert hipo to root files.

The freehep repository URL should be changed to https://... to avoid conflicts with recent maven versions that are blocking http repositories

Ability to save IDataSets similar to jroot. Requested by @forcar

Setting GStyle.setPalette("kViridis") at the top of main doesn't change the color palette of the first plot, only the subsequent plots.

• Requested by HTCC and FTCAL groups

Hi @gavalian , @wphelps , This isn't urgent, but it would be nice to be able to make plots like this one: https://userweb.jlab.org/~nathanh/pip_5DaccPlot_scanPhih.gif

Hi,

can you please add an option to link points of a GraphErrors with lines?

Thank you in advance

@wphelps @gavalian It seems that subscripts are not yet implemented in the histogram and axis titles (e.g. "x_B"). However, superscripts are working fine.

• Statbox options for all datasets
• Fit results statbox options with goodness of fit /ndf
• Statbox Position

Font size for the scaling factor doesn’t change with axis label font.

@wphelps would it be possible to save an entire DataGroup to a hipo file instead of saving the datasets one by one?

This will allow greater flexibility for users to specify stat box position and pad margins via the GUI or API.

• Implement PadAttributes
• Add PadAttributes to OptionsPanel
• Add PadAttributes to GStyle

EmbeddedCanvas produces an IndexOutOfBoundsException when drawing an empty histogram. Reported by Cole.

@wphelps @gavalian I've notice that my canvases are often drawn initially with some ugly overlaps/cropping, but when I drag the corner of the window it refreshes and then looks fine. Do you know why this is? I attached some before/after images to show the point.

Before:

After:

Could you please provide a license to the groot project?
Until then, I am not able to use your code.

Note: My preference would be MIT License, but please feel free to pick what makes sense for you.

Great library. It would be good to export images to vector graphics

Requested by nick

Hello, I was wondering whether you could add a few plotting features for 2D histograms (no hurry) - what I'd like to plot are 2D simple 2D histograms by markers (not by the usual color scale), so to study the distribution of points and eventually compare several distributions superimposing more plots with different markers. It would be nice to be able to set a marker style, and select a color for each histogram.
It could also be helpful to plot the H2F object as "box" (which is already possible), but selecting a different color per histogram so to allow, again, a visually meaningful superimposition (I don't think this is possible as of now for H2Fs).
Thanks!

Recent change of EmbeddedCanvas.update():

    JFrame topFrame = (JFrame) SwingUtilities.getWindowAncestor(this);
    topFrame.getContentPane().setVisible(false);
            this.repaint();   
    topFrame.getContentPane().setVisible(true);

causes my various TextEntry fields in the topFrame to stop working if Timer if firing off repeated updates to refresh the canvas. I can always replace canvas.update() with canvas.repaint() to prevent this, but the above code doesn't look like something we want this class to do.

• Copy/Paste datasets complete
• Copy Pad/Canvas image
• Save/Save as Canvas image
• Popout pad
• OptionsPanel
  • Quick action/summary pane
  • Advanced Options: Axes
  • Advanced Options: Datasets
• FitPanel

Three suggestions:

1. Replace ArrayList with synchronized list (avoiding thread collisions):
   // ArrayList fitResults = new ArrayList();
   List fitResults = Collections.synchronizedList(new ArrayList());

2. Remove progress code with Thread.sleep which was evidently intended to minimize thread collisions. This speeds up ParallelSliceFitter by at least x10.

3. fitResults are filled from slice threads and therefore not in ascending bin sequence. Resort:
   fitResults.sort(Comparator.comparing(FitResults::getPoint));

• Stat box for 2D histos showing NENTRIES (total attempts to fill histo) and NEVENTS (attempts which satisfy xmin,xmax,ymin,ymax)
• LatexText text doesn't move with pad (when double clicking on pad)
• LatexText refreshes without erasing leading to text bleeding after several refreshes.
• Request equivalent of PAW key command (symbol legend and text)

@wphelps @gavalian Sometimes axes have no min and max values:

Could you do something a little more sensible in dealing with negative values for log plots. Just assign some default color (gray) to values <= 0, instead of value=0 as done now. As currently configured, even if zmin is set >0 the histogram is rejected for containing a negative value. Another improvement would be to allow zmin to be fixed while zmax is allowed to autoscale.

When trying to save histograms into a hipo file, one of them (and its directory) always disappears (the first directory created).

Minimal example:
(tested with coat-lib 4.0 from coatjava 5a13 and tested with coat-lib 5.1 from coatjava master on February 16)

TDirectory dir = new TDirectory();
H1F h1 = this.get1DHisto(plotName);
dir.mkdir("/calibration/PCAL");
dir.mkdir("/calibration/ECIN");

dir.cd("/calibration/ECIN");
dir.addDataSet(h1);
dir.cd("/calibration/PCAL");
dir.addDataSet(h1);
        
dir.writeFile("testfile.hipo");
        
TDirectory diread = new TDirectory();
diread.readFile("testfile.hipo");
diread.cd();
diread.ls();

• Log scale in x and y axes
• Log scale in z axis

How to get the fit parameter uncertainties displayed in the stat box? I tried various setOptStat arguments but failed.

Since recent groot pull I notice tops of plots getting chopped, overflowing out of their frame boundaries (top plot) or looking like some other plot is underneath them (bottom plot).