gavalian / clas12tool Goto Github PK

If this is supposed to be the "official" repository for the clas12 tools it should be moved over to the jeffersonlab github so it can be worked on by everyone. If not then please add any changes you want to https://github.com/JeffersonLab/hipo_tools so that we don't have multiple repos with similar purposes.

At Hipo/utils.h, line 55
std::chrono::time_point<std::chrono::steady_clock> first, second;
causes a compile error at ifarm at least to me.

I'd suggest
std::chrono::time_point<std::chrono::high_resolution_clock> first, second;
as in the Hipo4/utils.h.

Gives a seg fault when reading from the bank exceeds number of rows.

I noticed that if a bank is read in event N, but the bank is not present in the event N+1, still the bank retains the previous event.

When dictionary is not read, or does not contain the schema,
bank is not properly initialized, add a warning.