garyjones / daterange Goto Github PK

@AMNDesign wants to have a format of M jS Y (albeit with <sup></sup> tags, but that's redundant here) and have an output like Jun 25th – 28th 2018 - that is, with the Month part always displaying on the start date.

Where the months differ, it should display like Jun 25th – Jul 28th 2018.

The issue stems from the current logic which assumes that the end date format stays consistent, and only the start date is consolidated.

A string like 'd~M\Y', 'd~M\\Y' and 'd~M\\\Y' are not handled correctly. Current unit tests fail, since the output includes Y, when it shouldn't.

A string like 'M j<\s\up>S</\s\up> Y' does pass, thanks to the crude attempt at handling escaped characters.

DateFormat::isEscapedCharacter() function needs revisiting.

The new approach in 0.2.0 needs an exception for hours, minutes, and seconds since they will always appear in the order where the next character represents a smaller time part.

A string like 'YdMymdMYDm' is not handled correctly, due to the new approach in 0.2.0.