Git Product home page Git Product logo

teacozy's People

Contributors

gary9630 avatar

Watchers

 avatar

teacozy's Issues

#location div location boxes off center

tea_cozy

Either you have to use padding/margin to push those boxes down, or you have to convert the location div into a flex box and make adjustments to center everything.

Summary

Overall met expectations.

You did a good job matching the website spec. Everything was well organized and setup properly.

Your focus should be more gear to best practices in organization and efficiency.

The location div positioning is minor but it needed to be pointed out.

I also typically looked for unneeded css which is why pointed out the flex wrap usage.

As a challenge use media queries to make this site look like a mobile app on a mobile device.

This will help prepare you for the upcoming projects as they will be having use media queries quite frequently.

Comments

Great that you are using them in the html, to make things easier to line up, have matching comments in the CSS file.

Flex Wrap

.location-container{
display: flex;
justify-content: center;
flex-wrap: wrap;
}

We don't need flex-wrap in this container. If you use the chrome tools to remove it, you will see nothing changed.

Now on the other hand if you remove it from the tea container everything breaks. So the idea here is if you are expecting to have enough items to need to wrap them then use it.

In general unneeded code in our css makes it look like we are just slapping things on to see what works so better to clean this up and double check your css after you visually reached your goal.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.