prj-rev-bwfs-dasmoto's People
prj-rev-bwfs-dasmoto's Issues
right tag for the right job
We don't really want the price text to be a link, we do want it to be blue. Use a span or even better a <strong>
tag since we want it to be default bold.
https://github.com/gary9630/prj-rev-bwfs-dasmoto/blob/master/Unit2_Dasmoto/index.html#L14
SUMMARY
Grade: Satisfactory
Summary: Nice job on this project, the page looks good. You used some good techniques here and kept your code organized. Take a look at the issues I created, they will give your some tips on organization and efficiency. The next part of the course is going to have much larger more complex projects and it will be important to be efficient and organized. Here are some good tips as well: http://learn.shayhowe.com/html-css/writing-your-best-code/
good class
This is a good place to use a class, and a good name since it describes the component it is styling.
html sections
See how you have naturally split your html into sections, take it to the next level and wrap those elements in their own div. Then move the class to the div to act as a section label, while still being able to uniquely target the h2's:
.brushes h2 { }
https://github.com/gary9630/prj-rev-bwfs-dasmoto/blob/master/Unit2_Dasmoto/index.html#L11-L14
use efficient css
Notice how you have to keep setting the font for each selector. Instead set the font for all elements in one place using inheritance:
html { font-family: Helvetica; }
Now all elements will inherit this font from html.
header tags bold
Header tags (h1,h2,h3...) default to bold, so no need to add it.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.