Git Product home page Git Product logo

elm-svg-parser's People

Contributors

billstclair avatar elm-review-bot avatar garados007 avatar rnons avatar simonh1000 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

elm-svg-parser's Issues

Need to handle DOCTYPE part

I'm using your library but found that I had to do some preprocessing to remove the DOCTYPE part. In the examples I had before the DOCTYPE part was on a new line and I did a simple String.startsWith("<!DOCTYPE) but that wasn't clever enough for this trivial example that puts everything on one line

I can see that you already look for and remove the <?xml part. Could you do the same for <!DOCTYPE...>?

<?xml version="1.0" ?><!DOCTYPE svg  PUBLIC '-//W3C//DTD SVG 1.0//EN'  'http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd'><svg enable-background="new 0 0 24 24" id="Layer_1" version="1.0" viewBox="0 0 24 24" xml:space="preserve" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><path d="M21,11v8c0,1.1-0.9,2-2,2H5c-1.1,0-2-0.9-2-2V5  c0-1.1,0.9-2,2-2h9" fill="none" stroke="#000000" stroke-miterlimit="10" stroke-width="2"/><polyline clip-rule="evenodd" fill="none" fill-rule="evenodd" id="13" points="  21.2,4.6 11.2,15.2 6.8,10.8 " stroke="#000000" stroke-miterlimit="10" stroke-width="2"/></svg>

Update Readme.md

Make the Readme.md more cleaner and understandable what this project is for. Also include examples.

Archive hash has changed for 1.1.0

I've got a following error when trying to build an existing project that depend on 1.1.0:

-- CORRUPT PACKAGE DATA --------------------------------------------------------
 /home/jenkins/jenkins-agent/workspace/.../frontend/elm.json
 
 I downloaded the source code for Garados007/elm-svg-parser 1.1.0 from:
 
     https://github.com/Garados007/elm-svg-parser/zipball/1.1.0/
 
 But it looks like the hash of the archive has changed since publication:
 
   Expected: 4ce4bbe7dd38c507758896f8b563c8ec4f555b33
     Actual: e877f72c927587c6c02d071c561189ce29c11545
 
 This usually means that the package author moved the version tag, so report it
 to them and see if that is the issue. Folks on Elm slack can probably help as
 well.

It looks like the tag was moved ~2 hours ago.

Handle xml namespaced attributes correctly

This error came up in PR #3. It seems like that namespaced attributes of the svg elements need special treatments with VirtualDom.attributeNS and cannot be supplied directly to VirtualDom.attribute. A general (but a hacky-ish) fix would be to check if the attribute name starts with a well known prefix like xlink: and use the namespaced version for this.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.