make hsm code be consistent with file and class naming conventions about galsim HOT 4 CLOSED

SBProfile isn't totally self-consistent either (and it certainly isn't consistent with the LSST conventions we're loosely following, though I'm not suggesting that it should be).

I wouldn't recommend making changes deep within your source files; it's probably more important that HSM be similar to other incarnations of HSM elsewhere.

from galsim.

Here was my rationale (and let me pull @barnabytprowe into this conversation) -
It's true that SBP is not consistent with LSST conventions. So eventually if we have new code according to LSST conventions, SBP, and hsm code, we will have 3 conventions running around. Given that hsm is not a lot of code, I thought we could at least reduce it to 2 conventions to be slightly less annoying. Also, to clarify, I was not going to make tons of changes deep in the code. The changes I had in mind were mainly related to file naming conventions (e.g., Psfcorr.h instead of psfcorr.h) and classes (e.g. I have OBJECT_DATA whereas our class naming convention does not have all-caps, and for consistency with SBProfile, ObjectData would make more sense). These are pretty simple and would fix the most glaring things. SBProfile lacks internal consistency in naming conventions for functions, so I wasn't going to make any changes to those in my code either.

from galsim.

Can I add this to credo.txt:

" We will adopt the SBProfile capitalization style wherever sensible for code filenames, as it's by
far the most significant chunk of C/C++ we are currently using. This makes include/*.h files
capitalized. "

The Class name convention is covered broadly by the LSST style anyway...

from galsim.

Sounds good to me.

from galsim.