Comments (2)
rmjarvis
commented on June 25, 2024
Thanks Jean-Eric. I finally had some time to look into this.
First, you're quite correct that that bit of code is missing a power of k^-1. However, even fixing that, this approximation, using the high k asymptotic behavior, seems not to be a very good one for finding maxk. Especially for larger beta values, where that asymptote doesn't kick in until much higher k than what we need for maxk.
So I ended up scrapping that and just doing a proper fit for maxk using the real formula with the Bessel K function. It's plenty fast enough for this purpose, so there's not really a big need to do an approximate calculation.
I'll have a PR for this shortly.
from galsim.
jecampagne
commented on June 25, 2024
Hi, I'm glad to make GalSim better :)
from galsim.
Related Issues (20)
- Small Discrepancy between Real and Fourier Space Shift HOT 4
- Colab install failed error: metadata-generation-failed HOT 1
- Monochromatic SED HOT 2
- BUG in FFTs? HOT 5
- Remove hidden scipy dependency
- SED flux type units lost in translation HOT 2
- Installation issue (FFTW problem with Apple ARM) HOT 2
- define `origin` and `world_origin` for CelestialWCS classes? HOT 8
- CelestialWCS method docstring erratum?
- Quintic interpolant (ALT_QUINTIC) uval: sign pb HOT 2
- Construct images without sanity checks in `_convertMask` function in the HSM module HOT 5
- New quintic kernel for interpolation in Fourier Space
- Sum over ghosts or use a diffrent formula for periodic cardinal sinus.
- maxk approximation used in Exponential profile HOT 2
- Spergel shoot photon for nu<0 HOT 2
- Accept pathlib.PosixPath in places where a basestring file_name is currently allowed.
- `save_photons` does not work for `ChromaticAiry` HOT 1
- Image array throws error about having no setter but still performs operation HOT 9
- numerical issue for some realizations of atmosphere HOT 29
- DoubleZernike.__call__ ought to handle integers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from galsim.