Construct images without sanity checks in `_convertMask` function in the HSM module about galsim HOT 5 CLOSED

Probably simplest would be to add a leading underscore version of this _FindAdaptiveMom that skips all the sanity checks and requires that object_image and weight are already the right dtype and everything.

from galsim.

That sounds like the least disruptive approach to me (not saying that modifying _convertMask would have been), but I could see a user potentially calling FindAdaptiveMom with inconsistent inputs. I'm happy to code this up, quantify the performance improvements and raise a PR here.

from galsim.

I think the main thing is probably that there are a couple of checks currently that the mask is sane (no negative values and not all zero). So probably adding an option to skip those will speed this up a lot.

from galsim.

An additional public interface to observed_e1 and observed_e2 would also be nice. And the current return for observed_shape should probably use the optimized _Shape rather than Shape.

from galsim.

Closing this issue as completed.

from galsim.