License: Other

JavaScript 100.00%

js-function-context-this-diagnostic's Introduction

JavaScript Scope and Context Diagnostic

The purpose of this diagnostic is to determine whether you can identify the value of this when invoked in differenct contexts.

Prerequisites

ga-wdi-boston/js-function-context-this

Instructions

Fork and clone this repository.
Change into the new directory.
Install dependencies.
Create and checkout a new branch, named response.
Follow the directions given in lib/diagnostic.js.
Before the alotted time is up, push to your fork and issue a pull request.

Your pull request description should contain a "fist to five" for comfort and clarity. Additionally, you should mention the resources you used to help you complete this assessment. For example:

Comfort: 3
Clarity: 3

I used Google and my class notes to help with this assessment.

You may wish to refer to "How do I submit diagnostics?" and other FAQs related to forking, cloning, and pull requests.

You may use any resource other than each other to complete this diagnostic. This includes referencing talk materials, appropriate documentation, and searching for help online.

You should be running grunt nag before diagnosing any bugs, since it finds some of the most common sources of errors. After grunt nag passes, you should run grunt test to run the included tests. Tests will tell you whether of not your responses are correct.

Note: For this diagnostic, grunt nag will complain about example code we have provided for the questions. You are not required to fix this warnings. Only fix warnings that occur on lines you have written for your response.

License

All content is licensed under a CCBYNCSA 4.0 license.
All software code is licensed under GNU GPLv3. For commercial use or alternative licensing, please contact [email protected].

js-function-context-this-diagnostic's People

Contributors

Stargazers

Watchers

Forkers

kristenlk gholmes04 maksimhn aemassa tiffboors29 payne-chris-r joebegley15 ryoconnell baz1389 pguzman26 eshimel gotwilk890 teopaolucci drewster317 mkutter72 raq929 francescadal bbarbersox leahphuong atsundwn kaylal12 tictacktone jcmeyer10 laurisaneuwirth faetea cwcrane akjones2007 sarabrentmccoy christinemoses laurengrant kpie89 rchezrutt88 edesilets dumplingpuff mfbrewster jdamiron jpfriedman18 byau knguyen21 carlamays24 natdjerf louarnos sjf125 olivia-leach rdelvallej32 soynog michaelb167 philschoof susandaiute shireen-bean jacobhereford andreasantarl lcurran modularjon tfavazza erinsul esthercordova roobscoobs huey1021 mishaherscu mattb5 computingbets sarahhartwick alex-braun natasapeic natgalynker gabescarbrough jlmitch1989 dvdpwll echoxin wmcb91 kopius bmorse09 viohlet knoddin rhjones jaimegaribaldo7 tuckyeah julie1013 nishkixs chrxtina nlkassad laurenallegra rosmith76 jenboyd styletabtech abeers bullhead242 treep78 ielole kiraamaa jdaly04 beckyd4234 sphilippe7 kibs86 kmg1434 naki21 matthewgsommers kfili jbuzzanco

js-function-context-this-diagnostic's Issues

ga-wdi-boston/js-function-context-this-diagnostic

Instructions unclear

Insert a line between 7 and 8 that invokes fire.

Is this asking students to create a property on deathStar to hold the result of deathStar.fire?
i.e.

/*1*/ var alderaan = { name: 'Alderaan' };
/*2*/ var deathStar = {
/*3*/   laserQuantity: 1,
/*4*/   laserSize: "huge",
/*5*/   fire: function fire(){
/*6*/     conosole.log(this);
/*7*/   },
          iife: (this.fire)()
/*8*/ };

Descope and clarify

This assessment is too long. Instead of having students refactor code, ask few questions and provide them with the code necessary to complete.

Diagnostic not in line with lesson.

This diagnostic seems to be about scope, whereas the lesson was about this. (Which also has to do with scope, but isn't tested here.) I think it needs reworking.

Add tests for verification

Edit the README and uncomment instructions for testing.

Add node template tooling

Grunt configurations
package.json

Then edit README and uncomment note about npm.

Tests are too easily tricked into passing

The questions should have better answers or tests so that they are less easily solved or give developers a passing test too broadly.

Question 1: Too easy to just run the code in the console and get the answer
Question 2: Too easy to just run the code in the console and get the answer
Question 3: Developer can enter the resulting string and not the method call to trick test
Question 4: Developer can just write a function that returns the string and trick test

// Suppose we had declared another function between line 7 and 8. Would that
// new function have access to the value stored in the variable `laseQuantity`
// on line 3?

laserQuanity

ga-wdi-boston / js-function-context-this-diagnostic Goto Github PK