Git Product home page Git Product logo

g5-orion-vagrant's People

Contributors

dpetersen avatar jlsuttles avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

jlsuttles

g5-orion-vagrant's Issues

Replace outdated cookbook architecture with g5stack

If we use the base box from G5/g5stack, we can remove almost all of the Chef code from this project, and we will automatically get any common updates (e.g. upgrading Ubuntu). We can replace the git submodules with berkshelf.

Remove unnecessary global environment variables

The current build scripts set up multiple environment variables that probably aren't necessary, including HEROKU_APP_NAME. Setting this particular env var causes issues with the g5-hub test suite. It doesn't make much sense to export this variable globally in a development environment that hosts multiple apps, each of which uses dotenv to manage its own development environment.

The program 'rails' is currently not installed.

$ vagrant up
$ vagrant ssh
$ cd /g5-content-management-system

Needed to sudo apt-get install rails before bundle exec rails server

Also note that rails server resulted in a "undefined method `write_inheritable_attribute' for Rails::Generator::Base:Class" error. Adding bundle exec to the command fixed this. We may want to add that to the README.

Setting RAILS_ENV causes problems

Hey @jlsuttles, I was getting some test failures that ended up being some test gems not being required automatically by bundler as usual. I unset the RAILS_ENV variable (which you added recently) and the gem became available as expected.

The only place I've seen a real environment variable set like that is on production servers, where you don't expect to run multiple environments. Unless there was a reason I'm missing, I think we should revert that commit.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.