g13nn / email-framework Goto Github PK

So currently the framework uses the default font Arial, I'm going to add scripts commented out in the boilerplate & mail.css. This can be used when you want to use custom or google fonts in your email templates. For the clients that don't support custom or google fonts it will fallback to Arial.

Hi Glenn,

First, thank you for sharing your work with us !

In the boilerplate you add an image "images/spacer.gif" but the file is not in the repo, is this normal ?

Not an issue per se, but I noticed that you had to add a space to a non-breaking space HTML entity in order for the characters to actually appear on the page, otherwise it would've looked like an empty element.

It looks like this & nbsp; instead of like this  

Why don't you just use the <code> tag instead of a <span> with inline styles?

Greate job with this email framework +1.

Hi Glenn,

Nice job.

Another day was testing your template and in first it was not working on mobiles, but after some research find out that in style section missing "mobile-hide" class which hide spacer.

Documentation on http://emailframe.work/ is down :- (

The server at emailframe.work can't be found, because the DNS lookup failed. DNS is the network service that translates a website's name to its Internet address. This error is most often caused by having no connection to the Internet or a misconfigured network. It can also be caused by an unresponsive DNS server or a firewall preventing Google Chrome from accessing the network.

Some images appear to be squashed in Outlook 2013. Currently looking into this.

Fix : Add line-height & height to style on surrounding td

Nice framework, I'll definitely look into it when I consider a redesign for my newsletter (and I'll be sure to promote this in a future issue)!

Just one thought...

For the primary domain, I notice you don't redirect the site for www vs. non-www.

You should pick one and redirect the other to the one you picked. I believe it's bad for SEO to not redirect. I suggest dropping the "www", as it looks cleaner and nicer with just "emailframe.work" in the address bar. Here's how to do this in htaccess, from HTML5 Boilerplate:

<IfModule mod_rewrite.c>
    RewriteEngine On
    RewriteCond %{HTTPS} !=on
    RewriteCond %{HTTP_HOST} ^www\.(.+)$ [NC]
    RewriteRule ^ %{ENV:PROTO}://%1%{REQUEST_URI} [R=301,L]
</IfModule>

Thanks!

The mobile version doesn't seem to be taking effect on Gmail for Android. All other mobile versions work fine, except this one. I suspected I had done something wrong, but then copied and pasted your exact "responsive-grid-master.html" and got the same result.

Test on Litmus:

So currently this email framework does not support "The Hybrid Coding approach". Currently it uses a 1px gif at the top of the email. This will force android clients to display the desktop version of the template.

It would be good to build this into the framework. We could create a folder and re-do each part of the framework so we can still keep the old setup, or just build it straight into the framework as is...

Resources :

• http://labs.actionrocket.co/the-hybrid-coding-approach
• http://labs.actionrocket.co/the-hybrid-coding-approach-2
• https://github.com/fcarneiro/tedc15_template
• http://webdesign.tutsplus.com/tutorials/creating-a-future-proof-responsive-email-without-media-queries--cms-23919

We just pushed http://github.com/voidlabs/mosaico an email template editor.
Would you mind if we adapt your template to be used inside mosaico?
Can we redistribute the adaptation under the GPL license?

Website suppose save visited IP, so to reproduce need unique IP "not visited" on this site.

Bad code possible see with back (undo) history button and disable Javascript (to block run meta refresh tag or window.location redirect inline script).

Outlook 2013, 2016
Don't show radius or rounded corners

Best practice would be to show in email client preview and hide in the opened email.

Hello,

I've been planning on using your great templates on my project.
But I'm seeing a lot of content deleted in the past 5 days: could you tell me why ?

Thanks

Hello everyone;

We are using email-framwork for our mails. Sometimes we need to seperate views for device width. For example; For mobile and desktop using different view, so we decided to use mobileOn and mobileOff, but when we add <style> at the top of page, It didn't work in gmail. Gmail removes all <style> tags, so the mail view is shown as desktop.

How can we fix. Thanks

Outlook overrides table cell font family if one is not defined in cell styles.

So in your grid examples every cell should be replaced with something like this:

<td width="600" class="mobile" style="font-family: Arial; font-size:12px; line-height:18px;">
    Grid One
</td>

The default iOS mail app is not being recognized as a mobile template. My email works fine in every other app and browser I'm testing. Am I missing something? I am currently testing on an iPhone 7.