Git Product home page Git Product logo

libctf's Issues

ctf_randfd is broken for stdin

You cannot call ctf_randfd on stdin.

getrlimit(RLIMIT_NOFILE, {rlim_cur=1024, rlim_max=64*1024}) = 0
open("/dev/urandom", O_RDONLY)          = 3
close(3)                                = 0
dup2(0, 0)                              = 0
close(0)                                = 0

I recommend the following fix:

diff --git a/ctf.c.1 b/ctf.c
index 2fabd62..4781277 100644
--- a/ctf.c.1
+++ b/ctf.c
@@ -250,11 +250,11 @@ int ctf_randfd(int old)

     // randomize new file descriptor
     if (fd < 0) {
-        while (new < old) {
+        while (new <= old) {
             new = rand() % max;  // fall back to rand() if fd was invalid
         }
     } else {
-        while (new < old) {
+        while (new <= old) {
             read(fd, &new, 2);
             new %= max;
         }

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.