Comment on problems in added lines of pull requests in Atlassian Bitbucket Server (formerly Stash)
Home Page: https://rubygems.org/gems/face_control
License: GNU General Public License v2.0
When wrong credentials are provided in ~/.stashconfig.yml, face-control is throwing an exception:
+ face-control FRNT app 939
/var/lib/jenkins/.rbenv/versions/2.3.4/lib/ruby/gems/2.3.0/gems/face_control-0.9.0/lib/stash/pull_request/diff.rb:21:in `diffs_with_added_lines': private method `select' called for nil:NilClass (NoMethodError)
from /var/lib/jenkins/.rbenv/versions/2.3.4/lib/ruby/gems/2.3.0/gems/face_control-0.9.0/lib/stash/pull_request/diff.rb:9:in `filenames_with_added_lines'
from /var/lib/jenkins/.rbenv/versions/2.3.4/lib/ruby/gems/2.3.0/gems/face_control-0.9.0/lib/stash/pull_request.rb:13:in `filenames_with_added_lines'
from /var/lib/jenkins/.rbenv/versions/2.3.4/lib/ruby/gems/2.3.0/gems/face_control-0.9.0/lib/face_control/cli.rb:27:in `check'
from /var/lib/jenkins/.rbenv/versions/2.3.4/lib/ruby/gems/2.3.0/gems/face_control-0.9.0/lib/face_control/cli.rb:15:in `run'
from /var/lib/jenkins/.rbenv/versions/2.3.4/lib/ruby/gems/2.3.0/gems/face_control-0.9.0/exe/face-control:5:in `<top (required)>'
from /var/lib/jenkins/.rbenv/versions/2.3.4/bin/face-control:22:in `load'
from /var/lib/jenkins/.rbenv/versions/2.3.4/bin/face-control:22:in `<main>'
I, [2017-09-05T12:23:23.242628 #29730] INFO -- : Running checkers...
D, [2017-09-05T12:23:23.269745 #29730] DEBUG -- : [HTTParty] [2017-09-05 12:23:23 +0000] 401 "GET https://www.server.net/rest/api/1.0/projects/app/repos/fapp/pull-requests/939/diff?withComments=false" -
D, [2017-09-05T12:23:23.269782 #29730] DEBUG -- : Response:
{"errors":[{"context":null,"message":"Authentication failed. Please check your credentials and try again.","exceptionName":"com.atlassian.bitbucket.auth.IncorrectPasswordAuthenticationException"}]}
+ exit 0
As of version 0.49, Rubocop could be run parallelized:
rubocop --parallel
Could you, please, implement this option?
Generation of comments for codetags is incorrect. Comments generates with string line point, but it must numeric.
Suggest using environment-specific configuration files instead of checking for Rails.env
Currently trying with the latest version which is 0.5.0 and i am getting the following error
/Users/administrator/.rvm/gems/ruby-2.2.2/gems/face_control-0.5.0/lib/face_control/inputs/rubocop_json.rb:20:in `block (2 levels) in comments': undefined method `include?' for nil:NilClass (NoMethodError)
from /Users/administrator/.rvm/gems/ruby-2.2.2/gems/face_control-0.5.0/lib/face_control/inputs/rubocop_json.rb:19:in `reject'
from /Users/administrator/.rvm/gems/ruby-2.2.2/gems/face_control-0.5.0/lib/face_control/inputs/rubocop_json.rb:19:in `block in comments'
from /Users/administrator/.rvm/gems/ruby-2.2.2/gems/face_control-0.5.0/lib/face_control/inputs/rubocop_json.rb:18:in `map'
from /Users/administrator/.rvm/gems/ruby-2.2.2/gems/face_control-0.5.0/lib/face_control/inputs/rubocop_json.rb:18:in `comments'
from /Users/administrator/.rvm/gems/ruby-2.2.2/gems/face_control-0.5.0/exe/face-control:30:in `block in <top (required)>'
from /Users/administrator/.rvm/gems/ruby-2.2.2/gems/face_control-0.5.0/exe/face-control:29:in `each'
from /Users/administrator/.rvm/gems/ruby-2.2.2/gems/face_control-0.5.0/exe/face-control:29:in `<top (required)>'
from /Users/administrator/.rvm/gems/ruby-2.2.2/bin/face-control:23:in `load'
from /Users/administrator/.rvm/gems/ruby-2.2.2/bin/face-control:23:in `<main>'
from /Users/administrator/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `eval'
from /Users/administrator/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `<main>'
it looks like the affected_extensions method is not being called correctly as i can't call it from irb using a proper pull_request object, and is returning nil when being called by the gem.
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.