fumr / tidal-async Goto Github PK

https://github.com/Fokka-Engineering/TIDAL/wiki/Authentication#deviceflow

We should consider caching creating instances of child classes of TidalObjects.
First thing that came to my mind is just caching TidalObject.from_id calls but again - I'm not sure if it should be done like this.
That would be an easy way.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/session.py:140. It will automatically be closed when the TODO comment is removed from the default branch (master).

Playlist field for id is named uuid, not id as in other objects
Should also fix @wvffle 's workaround with self.dict.update

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:182. It will automatically be closed when the TODO comment is removed from the default branch (master).

Playlist.tracks should call _fetch_items multiple times in LOOP (don't do recursion like that PLZ @wvffle)

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:203. It will automatically be closed when the TODO comment is removed from the default branch (master).

This issue has been automatically created by todo-actions based on a TODO comment found in pyproject.toml:22. It will automatically be closed when the TODO comment is removed from master.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:212. It will automatically be closed when the TODO comment is removed from the default branch (master).

needs FUMR/music-service-async-interface#5 to be resolved first

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:17. It will automatically be closed when the TODO comment is removed from master.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/session.py:353. It will automatically be closed when the TODO comment is removed from master.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/session.py:175. It will automatically be closed when the TODO comment is removed from master.

It works locally but fails with TimeoutError on github-actions.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/session.py:352. It will automatically be closed when the TODO comment is removed from master.

Android app doesn't send any request when clicking "Log out" button
Do we need this?

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/session.py:180. It will automatically be closed when the TODO comment is removed from master.

Needs #1 to be resolved

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:131. It will automatically be closed when the TODO comment is removed from master.

It wasn't updating issues pretty long.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:142. It will automatically be closed when the TODO comment is removed from the default branch (master).

eg. Parse chat message containing links to Tidal and return all corresponding objects

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/session.py:141. It will automatically be closed when the TODO comment is removed from the default branch (master).

Needs FUMR/music-service-async-interface#14 to be resolved.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:225. It will automatically be closed when the TODO comment is removed from the default branch (master).

• login process (not sure how to do this - it's interactive oauth2)
• session refreshing
• Track
  • loading track info
  • downloading tracks
  • track lyrics (no lyrics support atm)
  • track metadata generation
• loading album info
  • listing tracks from albums
• loading playlist info
  • listing tracks from playlists
• loading artists
  • listing albums from artists
• loading cover arts
• parsing URLs
• searching (first we need search)
• extracting client_id from Tidal Android .apk
• TidalMultiSession tests (what kind of?)
• caching TidalObject creation
  • caching of tracks
  • caching of albums
  • caching of playlists
  • caching of artists

This issue has been automatically created by todo-actions based on a TODO comment found in tests/test_tidal_async.py:8. It will automatically be closed when the TODO comment is removed from master.

Needs #1 to be resolved

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:262. It will automatically be closed when the TODO comment is removed from master.

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Preset caused unexpected error (config:recommended)

Preliminary (invalid) support for subtitles tag.
Subtitles are not supported in mediafile at the moment.
depends on solving the beetbox/mediafile#48

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:406. It will automatically be closed when the TODO comment is removed from master.

Until we can fill whole Enum it will still be used as a string.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:30. It will automatically be closed when the TODO comment is removed from master.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/session.py:354. It will automatically be closed when the TODO comment is removed from master.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:299. It will automatically be closed when the TODO comment is removed from master.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:261. It will automatically be closed when the TODO comment is removed from the default branch (master).

This issue has been automatically created by todo-actions based on a TODO comment found in tests/init.py:1. It will automatically be closed when the TODO comment is removed from the default branch (master).

Similar to tamland/python-tidal#62

eg. InsufficientAudioQuality

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:140. It will automatically be closed when the TODO comment is removed from the default branch (master).

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:138. It will automatically be closed when the TODO comment is removed from master.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/session.py:176. It will automatically be closed when the TODO comment is removed from master.

Today I got this.

aiohttp.client_exceptions.ClientResponseError: 429, message='Too Many Requests', url=URL('https://api.tidal.com/v1/tracks/38184307/lyrics?countryCode=GB')

Same goes for from_url
I was pretty sure I can just mark it @AbstractMethod and don't override it, but it looks like I was wrong

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:55. It will automatically be closed when the TODO comment is removed from the default branch (master).

If it can - run multiple requests

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:262. It will automatically be closed when the TODO comment is removed from the default branch (master).

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/utils.py:68. It will automatically be closed when the TODO comment is removed from master.

• login process (not sure how to do this - it's interactive oauth2)
• session refreshing
• Track
  • loading track info
  • downloading tracks
  • track lyrics
  • track metadata generation
• loading album info
  • listing tracks from albums
• loading playlist info
  • listing tracks from playlists
• loading artists
  • listing albums from artists
• loading cover arts
• parsing URLs
• searching
• extracting client_id from Tidal Android .apk
• TidalMultiSession tests (what kind of?)
• caching TidalObject creation
  • caching of tracks
  • caching of albums
  • caching of playlists
  • caching of artists

This issue has been automatically created by todo-actions based on a TODO comment found in tests/test_tidal_async.py:9. It will automatically be closed when the TODO comment is removed from master.

The only thing holding us from doing this is one asyncio gather call and HTTP library.
We could switch to httpx:
https://www.python-httpx.org/async/#supported-async-environments

• lyrics
• rewrite title parsing
• replayGain
• multiple artists

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:182. It will automatically be closed when the TODO comment is removed from master.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update music-service-async-interface digest to 018f62b
• chore(deps): update dependency pytest-asyncio to ^0.23.0
• fix(deps): update dependency http-seekable-file to v0.4.0
• chore(deps): update dependency pre-commit to v3
• chore(deps): update dependency pytest to v8
• fix(deps): update dependency androguard to v4
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

atm it will still be a string

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:31. It will automatically be closed when the TODO comment is removed from master.

~[Downloads]/t/tidal-async on master ❯ poetry install                                         at 15:48:44
Creating virtualenv tidal-async-6aH-m42I-py3.9 in /home/dedesvik/.cache/pypoetry/virtualenvs
Updating dependencies
Resolving dependencies... (2.0s)

  RuntimeError

  The dependency name for http-seekable-file does not match the actual package's name: httpseekablefile

  at ~/.poetry/lib/poetry/puzzle/provider.py:291 in get_package_from_directory
      287│         )
      288│
      289│         if name and name != package.name:
      290│             # For now, the dependency's name must match the actual package's name
    → 291│             raise RuntimeError(
      292│                 "The dependency name for {} does not match the actual package's name: {}".format(
      293│                     name, package.name
      294│                 )
      295│             )

How are you supposed to install and use this anyway? I just want my X-Tidal-Token...

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/session.py:46. It will automatically be closed when the TODO comment is removed from the default branch (master).

Tidal seems to migrate to DASH for their music streaming.
Instead of JSON manifest file encoded into Base64 there's .mpd XML file which seems to play just fine using ffplay.
Copying this into container-less FLAC format will be neccessary.
ffmpeg is doing this just fine with this cmdline:

$ ffmpeg -i tidal.mpd -c:v copy -c:a copy output.flac
[..]
Input #0, dash, from 'flac.mpd':
  Duration: 00:06:06.00, start: 0.000000, bitrate: 0 kb/s
  Program 0 
  Stream #0:0: Audio: flac (fLaC / 0x43614C66), 44100 Hz, stereo, s16, 505 kb/s (default)
    Metadata:
      variant_bitrate : 918113
      id              : 0
Output #0, flac, to 'output.flac':
  Metadata:
    encoder         : Lavf58.76.100
  Stream #0:0: Audio: flac (fLaC / 0x43614C66), 44100 Hz, stereo, s16, 505 kb/s (default)
    Metadata:
      variant_bitrate : 918113
      id              : 0
Stream mapping:
  Stream #0:0 -> #0:0 (copy)
[..]

Someone told me that Tidal blocks downloading of files simultaneously, but I didn't really noticed that

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/session.py:177. It will automatically be closed when the TODO comment is removed from master.

Now we have very similar code in Album.tracks, Playlist.tracks and Artist.albums

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:19. It will automatically be closed when the TODO comment is removed from master.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:100. It will automatically be closed when the TODO comment is removed from master.

WTF, android app doesn't send any request when clicking "Log out" button

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/session.py:118. It will automatically be closed when the TODO comment is removed from master.

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:110. It will automatically be closed when the TODO comment is removed from the default branch (master).

This issue has been automatically created by todo-actions based on a TODO comment found in tidal_async/api.py:17. It will automatically be closed when the TODO comment is removed from master.