fuellabs / swayswap Goto Github PK

The app should have a landing page with a brief description of what it is, why it's important and a button to get started.

Take Uniswap landing as an example.

Refs.: FuelLabs/faucet#1

• deposit coin A
• deposit coin B
• add_liquidity between this two pairs

Originally posted by @pixelsbyeryc in #53 (comment)

We need to see the balance of each asset during the Swapping phase (i.e. if I have Eth selected, how much do I have in my balance, see Uniswap)

If a user doesn't have a balance, SwaySwap should auto facuet me coin and present a message nicely saying "Fauceting you test Ether".

I shouldn't need to manually hit the faucet button.

Also, if you want the faucet button to be the primary action on the wallet page, then it should be in an action color like green to signal I need to press it.

This is a temporary fix to a compiler issue. Making it work, with a "single" parameter function.

Today some parts of the code only work with ETH -> TOKEN and TOKEN -> ETH.

Contracts

• Add methods to add / remove tokens to the list of supported tokens
• Add some way to insert / retrieve metadata to the tokens, like custom code/name and icon URL or binary.

Client

• Change static coins.ts to retrieve the list of token from the swayswap_contract with metadata (name, img)

Now we are calling each method in sequence.
This should be possible by creating a script with multiple CALL operations.

Depends on;
FuelLabs/fuels-ts#216

Today is very common to try to create a pool without checking the balances, this results in depositing one token and disrupts the experience.

This could also be fixed with #42.

How it works

When we run npm install we automatically copy the .env.example file to the .env.
On the .env we have;
REACT_APP_FUEL_PROVIDER_URL - Link for the fuel node
REACT_APP_CONTRACT_ID - Id of the swayswap contract Id
REACT_APP_TOKEN_ID - Id of the token contract id

Originally posted by @luizstacio in #60 (comment)

• We should add slippage on swap and pool this creates a tolerance if the reserves change during the time user hits swap and it goes through the contract
• To add liquidity to a pool users need to provide the same ratio as the existing pool

This link is uniswap v1: https://bafybeiehogk3rdmet7pd3ddtmz2pnsrivmdjvlnf5qczujl5plmkouispm.ipfs.dweb.link/
Here we can find also on other chains: https://github.com/Uniswap/interface/releases/tag/v1.0.0

When swapping, I noticed there is no error when I attempt to swap more balance of Ether than I have.

This should be prevented or stopped in the UI.

• fuel-core: release fuel-core with coin selection API (v0.3.2) @Voxelot (FuelLabs/fuel-core#178)
• fuel-core: run on the cloud @Voxelot
• fuel-core: SSL cert/ports @Voxelot
• fuel-core: mark coins as spent when tx runs @Voxelot
• fuels-ts: integrate with the coin selection API (check with JC) @luizstacio
• #20
• fuels-ts: generate secret key, sign txs @luizstacio
• frontend: very simple web wallet using the above TS SDK @luizstacio (#6)
• frontend: faucet: zero-input-one-output tx that gives user some coins @luizstacio
• #17
• frontend: github pages integration @luizstacio @adlerjohn #16
• frontend: drop-down @eureka-cpu (#8)
• language: make Result work @sezna @emilyaherbert
  • FuelLabs/sway#814 (comment) (nice to have)
  • FuelLabs/sway#308
  • implement if lets (FuelLabs/sway#815)
  • add size_of that hooks in to the compiler and gets the size of the type in bytes (low prio) (FuelLabs/sway#818)
  • json abi needs structs that are logged (low prio)
• stdlib: Result unwrap() function @adlerjohn (FuelLabs/sway-lib-std#90)

Better persistence on the inputs (i.e. if you type a number on one page, switch over to another, then come back, then it removes the value"

• Swap Page
• Pool Page

• Provide visual feedback that the address was copied

• swap_with_minimum
• swap_with_maximum

Compiling the following causes a warning:

contract;

abi MyContract {
    fn foo(s: S) -> S;
}

struct S {
    x: u:64,
}

impl MyContract for Contract {
    fn foo(s: S) -> S {
        s 
    }
}

Result:

❯ forc build
  Compiled library "core".
  Compiled library "std".
warning
  --> proj/src/main.sw:15:5
   |
13 |
14 | struct S {
15 |     x: u64,
   |     - This struct field is never accessed.
16 | }
   |
____

  Compiled contract "proj" with 1 warning.
  Bytecode size is 76 bytes.

The warning is out of place here since this is perfectly legal code and even though x is never accessed in foo directly, it is being implicitly used.

The pooling mechanism in SwapSwap took my Ether, but didn't check before if I even had the correct amount of Dai.

The pool mechanism should only take my ether if I have the right amount of both Dai and Ether.

Otherwise, it will take my Ether, and fail.

• #86
  • Something like this: "1 USDT = 0.0003696 ETH ($0.999656)"
• #82
• #83
• #84
• #85

• Deploy token contract to node.swayswap.io
• Add envs to the CI

We need Error / Success states for all major actions. If something is or isn't working, the user needs to know.

I can take the lead on this, since it might not be a priority for the team.

I'm testing a revamp to the design using Radix UI Colors.

Here's the Figma File I'm working with.

Colors:

• Accent colors: mintDark
• Neutral colors: slateDark

Font: Inter (with a few caveats)

Icons: Heroicons - a library from the guys that created TailwindCSS.

Let me know what you think, how it's looking. I'll introduce some of the changes in future commits. Don't want to proceed with the PR until we have some of these things "approved". @luizstacio in this case, should I open a new issue and move the PR to a draft? What's the best practice?

Preview

Entire UI (WIP)

Menu Item States

Menu Wallet Design (WIP)

Originally posted by @pixelsbyeryc in #53 (comment)

The current approach is navigate the user to the assets page.

When the invert button is clicked, the field to be calculated is cleaned, while we wait to get the amount. Let's add a loading feedback in the input.

Today we have an issue that limits values to create pools to 0.000001 and swap 0.00000001 it should be possible to work all values.

Show a transaction preview, before sending the transaction

Depends on;
FuelLabs/fuels-ts#217

These are no longer needed with the new parser. I would have done this now but I'm AFK until Wednesday.

TypeChain was recently updated to version v8. Much of the code in fuels-ts is using v6.

In issue 279 on fuels-ts, we are upgrading the dependency version, and then will update this project to use latest versions of TypeChain/etc.

• withdraw
• remove_liquidity

• Add validation of contract id, to match if is a valid address maybe some regex
• Add validation of contract id, maybe querying it from the node to make sure it exists

• Create support on token contract to set name and image url
• Add support on SwaySwap contract to list tokens
• Add support on SwaySwap contract to list pools
• Add support on SwaySwap contract to add tokens
• Add support on SwaySwap contract to add exchange contract

Root README

• Environment requirements
• How to run the docker
• How to build contract
• How to deploy contract
• How to run front-end
• Explain folder structure
• Setting env values
• ….

App REAMDE

• Explain folder structure