Git Product home page Git Product logo

Comments (4)

WanWizard avatar WanWizard commented on September 2, 2024

I have closed the PR, as it does not only contain the fix, but also changes to other parts of the code.

If those changes are necessary, create a seperate PR for them, explaining why. The current description says "beautifying", but the code also contains logic changes...

from oil.

findrakecil avatar findrakecil commented on September 2, 2024

Ah, yes.. I'm sorry. I thought that I could just include the related changes in the same issue.

I will make another PR just for this issue. And other PR for "beautifying" the generated code because I thought that the generated code was "ugly" 😅

from oil.

WanWizard avatar WanWizard commented on September 2, 2024

My problem is more that "beautifying" should not include logic changes. And I see for example a changed action_index() method without any explanation why...

from oil.

findrakecil avatar findrakecil commented on September 2, 2024

Ah, yes.. I'm sorry. Thank you for the guidance. I'll do better next time

from oil.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.