Git Product home page Git Product logo

Comments (2)

nojaf avatar nojaf commented on September 26, 2024

Hello, thank you for your interest in this project.
Some initial feedback:

  • You marked that this is part of the G-Research style guide although the guide does not provide any guidance from this specific case. You made an assumption that the same rules apply for function and match and how they should work in combination with the pipe infix operator. I'm sorry but this is insufficient as a basis for disucussion. Please open an issue in both style guides (MS & GR) so that this question can first be resolved over there.
  • If both style guides suggest something different than what Fantomas has today, we can change the style here. Please read more about this in our contribution guidelines. Fantomas only changes style if new information presents itself in the style guides.
  • The reason why the behaviour changed from 4.4 appears to be fsprojects/fantomas#1559, perhaps we missed something while solving this.
  • Fantomas does not guarantee the exact same output between versions. It evolves as style guides evolve, so the argument about the git diffs does not stand.

from fslang-design.

dsyme avatar dsyme commented on September 26, 2024

On the style guide question here - the code listed is sufficiently non-idiomatic that I don't think its formatting should deviate from the norms, the indentation is fine and does make the code easier to read (though less likely that construct will be used, which is fine). I'll close this

from fslang-design.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.