[style-guide] Presence of shebangs in scripts about fslang-design HOT 8 CLOSED

@nojaf fyi, might be interesting for you

from fslang-design.

If the lexer/parser can capture this in the syntax tree, Fantomas can restore it.

from fslang-design.

This can be captured, yes, we should treat this as an FCS/ fantomas bug

from fslang-design.

What's the next step then? Do I file a bug report in Fantomas, then try to fix it before v5 hits?

from fslang-design.

The next step would be to raise a PR to dotnet/fsharp that adds the shebang as ParsedHashDirective (I think).

You can open an issue in Fantomas, but you would get the same reply there.
This doesn't hinder the v5 release, we would accept a fix at any time for this.

from fslang-design.

Actually, after taking another look at this, it can be solved quite easily on Fantomas' side without any compiler changes.

Looking at the AST, the shebang is parsed as a line comment. There is a bug in Fantomas that doesn't recognize this as a line comment on a single line because it does not start with //.

@mataha, please report an issue on Fantomas' side. You can do this using the online tool.

from fslang-design.

@dsyme this was implemented in Fantomas a while ago, do we still need to do anything here?

from fslang-design.

This can be closed as completed.

from fslang-design.