Git Product home page Git Product logo

Comments (5)

Martin521 avatar Martin521 commented on May 23, 2024 1

I have not used routing myself, but as far as I understand it, the SetPage message is indeed not meant to be used by you, but only by the router. It is only a way to flexibly configure the router to manipulate the model in the right way.

from bolero.

Tarmil avatar Tarmil commented on May 23, 2024 1

Yeah, we can't really detect that a URL change was caused by the same message that it triggers. So it's best to avoid dispatching it directly. Instead you can either have a separate message like you did, or directly set { model with page = page } in the update for DoAThing.

Maybe the documentation should recommend calling this message something like PageChanged, to emphasize that it's not meant to be dispatched directly.

from bolero.

clbrem avatar clbrem commented on May 23, 2024

I've found a workaround, but it is not ideal.

type Message = 
| SetPage of Page
| Redirect of Page
| DoAThing

let update message model = 
  match message with
  | SetPage page -> 
     { model with page = page }, Cmd.none
  | Redirect page ->
    { model with page = page }, Cmd.none
  | DoAThing ->
    model, Cmd.ofMsg (Redirect NewPage)
let router = Router.infer SetPage (fun model -> model.page)

When DoAThing is dispatched from Home, Redirect NewPage is dispatched once, followed by SetPage NewPage. Any actions triggered by SetPage NewPage (i.e. fetching data, etc) would only be run once.

from bolero.

clbrem avatar clbrem commented on May 23, 2024

Maybe the documentation should recommend calling this message something like PageChanged, to emphasize that it's not meant to be dispatched directly.

This makes sense! Thanks all.

from bolero.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.