Comments (6)
go ahead with c), it would be nice if you could provide a matrix of what is/was accepted/rejected.
from semver-tool.
I just wanted to edit the source, as i discovered that the regex already accepts dots as parts of PRERELEASE and BUILD. Maybe the patch will reduce itself to just change the wording of the documentation.
stay tuned.
from semver-tool.
I think the patch attached is to the best of my abilities (sadly, i must say).
from semver-tool.
To summarize: Indeed i couldn't find any combination that didn't pass unit testing.
I wasn't convinced that my idea to handle error-cases in unit-tests is the best, so i didn't include it.
My idea would be this: reserve some special return value that's impossible normally. For example the value "@error". Write this value into the README.md in place where the expected result would be written. Then the script test/documentation-test could be extended to detect this value and then expect a non-zero exit status from semver.
Regarding the specified comparison rules of semver2.x with regards to prerel, i am not confident enough to say there's a bug without testing. but i didn't want to test without having the tests documented and repeatable -- thus the above mentioned feature of test/documentation-test would need to be resolved first.
However, i must be frank, that i could not guarantee time to go through with all the steps necessary to change test/documentation-test. therefore i will only promise to go through with the changes as proposed (and discuss any problems you might find).
from semver-tool.
As I had already opened the code box to fix issue #33, I decided to jump in and work on semver spec 2.0.0.
There is already an open pull request (#30) addressing this issue, so I don't want to yank this contribution around. Herr Pogner ( @qyanu), if you have moved forward on the pull request or plan to shortly, let us know.
On the other hand, if your PR is still at the 1-Aug-2019 state and is not going to more forward (you hinted above about time constraints and test-case doubts), I'm ready to publish a PR that should close this bug.
- It complies with 2.0.0.
- Automated unit tests show previous non-compliance as well as testing compliance. Basis for the "matrix of what is/was accepted/rejected" requested by @fsaintjacques.
- No changes to test/documentation-test.
- No CLI changes.
I'll be publishing my work shortly and will send a PR unless you'd rather I don't.
from semver-tool.
@ranger6 no no, i don't even read emails daily anymore. good days to you!
from semver-tool.
Related Issues (20)
- Portability: Function names containing hyphens HOT 2
- Inconsistent re-naming of "is-nat" HOT 1
- "bump prerel" should support numerical increments HOT 3
- travis-ci badge in README.md should be changed to a GitHub Action badge HOT 1
- "tag" badge in README.md file is inconsistent and confusing HOT 2
- atom/keyword returned by "diff" should match the atoms/keywords used by "bump" HOT 2
- "bats" test files are fragmented and inconsistent HOT 4
- Feature request HOT 7
- prerel compare issue HOT 4
- Create docs for installing on a travis agent HOT 3
- asdf plugin
- Feature request: command to validate if something is a semver HOT 2
- Request regarding "semver bump prerel" HOT 2
- README should factor out package manager installation notes HOT 5
- Is it expected, that prerel bump removes "v" prefix? HOT 2
- semver validate exit codes HOT 5
- Feature request: get '$major.$minor.*`
- Test dependencies obscure/confusing and not DRY HOT 5
- Dots are not allowed in prerelease identifiers HOT 2
- Support docker version with build number HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from semver-tool.