Git Product home page Git Product logo

Comments (2)

fsaintjacques avatar fsaintjacques commented on July 25, 2024

If you open a PR, I'll accept it since I think it improves readability. It shouldn't be too hard to implement. I would name the command validate, e.g. semver validate $version. I wouldn't use stdout for transmitting success, simply exit 0 if it's valid, 1 otherwise.

On this subject, the example can be simplified. You don't need the set +e / set -e guards and temporary variable, instead you can do the following:

if semver get major ${CURRENT_APP_VERSION} >/dev/null 2>&1; then
  ...
fi

The if operator in bash will swallow the return code of the command without aborting the execution of the script due to set -e.

from semver-tool.

mymasse avatar mymasse commented on July 25, 2024

I'll see if I have to make a PR over the holidays.

And thanks for the simplification of my bash snippet until we have the new command!

from semver-tool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.