froemken / repair_translation Goto Github PK

Currently the extension does not seem to work in TYPO3 v9 yet. Are there already plans here?

When the tca option "[behaviour][allowLanguageSynchronization]" of a field is set to false, this field won't be listed l10n_state. In this case configuredToUseDefaultLanguage (https://github.com/froemken/repair_translation/blob/master/Classes/SignalSlot/Repair.php#L216) should return false, but it doesn't when there are other fields configured in l10n_state.

Have i misunderstood something?
Is this a bug?

Hey Stefan,

ich habe noch einen Fehler gefunden. Wenn man sich im WS befindet und dann bei der Übersetzung eines Datensatzes ein bisher schon bestehendes Bild löscht (im Live schon übersetzt) und dann ein neues einfügt verschwindet das "Live" Bild nicht sondern wird weiterhin im BE und FE (WS) angezeigt. Ich hatte leider noch keine Zeit mir das Problem selbst anzuschauen aber wäre cool wenn du das auch noch in deine repair Extension einbauen könntest :)

Viele Grüße
Marc

Hi,
does my extension need special integration or configuration to show differnet image in translatet record? TYPO3 8.7.19

Exerpt from my moon_teaser/Configuration/TCA/Overrides/pages_language_overlay.php

'tx_moonteaser_image' => array(
        'exclude' => 0,
        'label' => 'LLL:EXT:moon_teaser/Resources/Private/Language/locallang_db.xlf:pages.tx_moonteaser_image',
        'config' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::getFileFieldTCAConfig(
            'tx_moonteaser_image',
            array(
                'maxitems' => 1,
                'appearance' => array(
                    'fileUploadAllowed' => FALSE,
                )
            ),
            $GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext']
        ),
    ),

Only the images from the original languages are shown .

Thanks in advance

Is there a possibility to provide this extension via packagist, so one could install it via composer?

Die Sortierreihenfolge bei tx_news Bildern unterscheidet sich zwischen der Originalsprache und der Übersetzung, auch wenn diese in den Datensätzen gleich ist.
Wahrscheinlich wird in getNewlyCreatedTranslatedSysFileReferences in Repair.php im SQL Query die Sortierung von sys_file_reference.sorting_foreign nicht beachtet.

Viele Grüße
Tobias

Hi

Could you please tag version 1.4.1 released on May 20, 2019.
Currently this one is only available in TER https://extensions.typo3.org/extension/repair_translation/.

Personally I prefer using the composer package directly from https://packagist.org/packages/stefanfroemken/repair_translation

It's rather a missing feature than an issue of course:

Are there any plans to add options for configuring the extension?
Once installed there are always the translations displayed, no matter how the language configuration of a single page is.

What I would appreciate is the possibility to determine (via TS) if the translation or the default record is being displayed in one case (or one page) or another.

Best,
barow

With this line in TCA:
'l10n_mode' => 'mergeIfNotBlank',
you always get the file from default language.
Imo it is caused by line 86 in Repair.php:
$this->isMergeIfNotBlankConfigured($translatedReference)

Imo it should be negated, because you dont want to override the translated file when it exists (!empty($translatedForeignRecord))

great extension !
But there is one small bug: it ignores the sorting of the files.
I fixed it by adding sorting_foreign to the query in /repair_translation/Classes/SignalSlot/Repair.php :

original:
$rows = $this->getDatabaseConnection()->exec_SELECTgetRows( '*', 'sys_file_reference', implode(' AND ', $where) );

new:
$rows = $this->getDatabaseConnection()->exec_SELECTgetRows( '*', 'sys_file_reference', implode(' AND ', $where), '', 'sorting_foreign' );

I have got a TYPO3 8.7.13 running with three languages. After updating repair_translation from version 1.2.2 to 1.4.0 all filelinks to files in the translated language were not displayed anymore. Only if the file was the same in all languages, the title of the file was displayed in the correct language.
But if a content element had links to different files in every language, these link were not displayed in the other languages any more.
Downgrading to 1.2.2 solved the problem.

Hey, just wanted to point out that:

The setting mergeIfNotBlank has been removed without replacement from the list of possible values of the TCA column property l10n_mode.

See:

• https://docs.typo3.org/typo3cms/extensions/core/Changelog/8.6/Breaking-79243-RemoveL10n_modeMergeIfNotBlank.html
• https://github.com/froemken/repair_translation/blob/master/Classes/SignalSlot/Repair.php#L85

Hi,
after the Installation i've got this exception:
`The given class "StefanFroemken\RepairTranslation\SignalSlot\Repair" is not a registered object. (More information)

TYPO3\CMS\Extbase\SignalSlot\Exception\InvalidSlotException thrown in file
/Users/daniel/Sites/mohn/corefiles/typo3_src-8.7.9/typo3/sysext/extbase/Classes/SignalSlot/Dispatcher.php in line 123.`

I cleared alle the Caches and temp-files.
Any Ideas what i can do?
Thx!