froemken / mysqlreport Goto Github PK

Extension is not working under TYPO3 11.5.30, but composer.json "require" says different: "^11.5.23 || ^12.2.0"
Also the ext_emconf.php says, it should be compatible with TYPO3 11.5.23 and up: 'typo3' => '11.5.23-12.5.99'

After install backend breaks with this error message:

Invalid service "dashboard.widget.mysql-max-used-connections": class "TYPO3\CMS\Dashboard\Widgets\DoughnutChartWidget" does not exist.

The class TYPO3\CMS\Dashboard\Widgets\DoughnutChartWidget is not available under TYPO3 11.5

An exception occurred while executing 'EXPLAIN SELECT backend_layout, backend_layout_next_level, uid FROM pages WHERE (uid = ) AND ((pages.deleted = 0) AND (pages.hidden = 0) AND (pages.starttime <= 1667920020) AND ((pages.endtime = 0) OR (pages.endtime > 1667920020)))': You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') AND ((pages.deleted = 0) AND (pages.hidden = 0) AND (pages.`starttim' at line 1

Missing uid value

in $sizeOfEachLogFile = (int)($bytesWrittenEachHour / $variables['innodb_log_files_in_group']);

there is imo no benefit in having times like "0.0057640075683594" i suggest to round it to something like "0.005764". this improves also the readability

The methods ProfileRepository::getProfileRecordsByUniqueIdentifier and ProfileRepository::findProfileRecordsForCall use incomplete groupby statements.
Furthermore the select part omit proper quoting.

For getProfileRecordsByUniqueIdentifier:

Quoting:
->add('select', 'crdate, unique_call_identifier, mode, SUM(duration) as duration, COUNT(*) as amount')
should be

->select('crdate', 'unique_call_identifier', 'mode')
->selectLiteral('SUM(duration) as duration', 'COUNT(*) as amount')

GroupBy must be:
->groupBy('unique_call_identifier', 'crdate' , 'mode')

For findProfileRecordsForCall:

Quoting:
->add('select', 'query_type, unique_call_identifier, SUM(duration) as duration, COUNT(*) as amount')
should be

->select('query_type', 'unique_call_identifier')
->selectLiteral('SUM(duration) as duration', 'COUNT(*) as amount')

GroupBy must be:
->groupBy('query_type', 'unique_call_identifier')

what about using e.g. https://github.com/doctrine/sql-formatter to show the query in a improved way? would be fine for composer based only to avoid custom autoloading

proposal:

• render table header only if records found
• show info box if no queries found and reason: no logging, no slow queries?

Uptime partial contains still status variables which are not available anymore.

Here is a good explaination of various MySQL settings:

https://vitux.com/tune-and-optimize-mysql-mariadb/?utm_campaign=T3A%20Newsletter&utm_medium=email&_hsmi=159278470&_hsenc=p2ANqtz-80swrmJK6tNiHr5mjuvH0PdUvM0TPjpD5AW0dX8azJ-Puje6SrrtXP1E2hJhgyWj6wGeU0VtwDOvLAf0F-wn1w6fTZAQ&utm_content=159278470&utm_source=hs_email

Would be good to have them in mysqlreport