Git Product home page Git Product logo

cron's Issues

Year support

Is it possible to add year support as seventh field of cron expression?

Switching Month/Year with given Month fails on nextTimeAfter

Hi,

there is a bug in the lib when cron switches to next month and a fixed month is set in the cron expression. Here are some unit tests which show the problem. Instead of switching to 00:50 the calculated time is 23:50.

    public void testSPSTriggerProblemSameMonth() {
        assertEquals(ZonedDateTime.parse("2020-01-02T00:50:00Z"),
            new CronExpression("00 50 * 1-8 1 *")
                .nextTimeAfter(ZonedDateTime.parse("2020-01-01T23:50:00Z")));
    }

    public void testSPSTriggerProblemNextMonth() {
        assertEquals(ZonedDateTime.parse("2020-02-01T00:50:00Z"),
            new CronExpression("00 50 * 1-8 2 *")
                .nextTimeAfter(ZonedDateTime.parse("2020-01-31T23:50:00Z")));
    }

    public void testSPSTriggerProblemNextYear() {
        assertEquals(ZonedDateTime.parse("2020-01-01T00:50:00Z"),
            new CronExpression("00 50 * 1-8 1 *")
                .nextTimeAfter(ZonedDateTime.parse("2019-12-31T23:50:00Z")));
    }

    public void testSPSTriggerProblemNextMonthMonthAst() {
        assertEquals(ZonedDateTime.parse("2020-02-01T00:50:00Z"),
            new CronExpression("00 50 * 1-8 * *")
                .nextTimeAfter(ZonedDateTime.parse("2020-01-31T23:50:00Z")));
    }

    public void testSPSTriggerProblemNextYearMonthAst() {
        assertEquals(ZonedDateTime.parse("2020-01-01T00:50:00Z"),
            new CronExpression("00 50 * 1-8 * *")
                .nextTimeAfter(ZonedDateTime.parse("2019-12-31T23:50:00Z")));
    }

    public void testSPSTriggerProblemNextMonthDayAst() {
        assertEquals(ZonedDateTime.parse("2020-02-01T00:50:00Z"),
            new CronExpression("00 50 * * 2 *")
                .nextTimeAfter(ZonedDateTime.parse("2020-01-31T23:50:00Z")));
    }

    public void testSPSTriggerProblemNextYearDayAst() {
        assertEquals(ZonedDateTime.parse("2020-01-01T00:50:00Z"),
            new CronExpression("00 50 * * 1 *")
                .nextTimeAfter(ZonedDateTime.parse("2019-12-31T23:50:00Z")));
    }

    public void testSPSTriggerProblemNextMonthAllAst() {
        assertEquals(ZonedDateTime.parse("2020-02-01T00:50:00Z"),
            new CronExpression("00 50 * * * *")
                .nextTimeAfter(ZonedDateTime.parse("2020-01-31T23:50:00Z")));
    }

    public void testSPSTriggerProblemNextYearAllAst() {
        assertEquals(ZonedDateTime.parse("2020-01-01T00:50:00Z"),
            new CronExpression("00 50 * * * *")
                .nextTimeAfter(ZonedDateTime.parse("2019-12-31T23:50:00Z")));
    }

The failing tests are:

testSPSTriggerProblemNextMonth
testSPSTriggerProblemNextYear
testSPSTriggerProblemNextMonthDayAst
testSPSTriggerProblemNextYearDayAst

I checked with v1.5 and v1.4.

Cheers Andreas

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.