Feature Request

There are tons of icons available, but the selection of free software and open systems is very limited. But I would love to have the exposure to free software and openness increased.

FYI: I come from freegamedev.net as a regular member (not an admin) which recently activated this plugin, that's how I know this plugin.

Describe the solution you'd like

I request to have icons added for the following open communications/systems/networks:

• XMPP
• Matrix
• diaspora*
• Signal
• PeerTube (joinpeertube.org)
• Pixelfed.org

Also, icons for …:

• Codeberg.org
• GitLab.com
• NotABug.org
• Launchpad.net
• SourceForge.net
• OpenDev.org
• Gitea.com
• OpenCollective.com
• Liberapay.com

(Feel free to add your own ideas)

Error recurrence: when adding a new profile, if the first one is left blank and the second one is filled with information, the user will disappear instantly after clicking Save. Although the user's information still exists in the database, the user's personal data will no longer be loaded on the forum, and only the discussion once published by the user can be browsed.

https://i.imgur.com/v7aNxDk.png

fof/socialprofile 0.1.2
flarum version: Flarum 0.1.0-beta.12

if you add a link to your profile and press save without an icon being selected or the loading icons spinning then it will select the loading icon as the icon for that link

if you press save now

it will look like this.

to fix this just remove the link, and re-add it. this time selecting an icon, or waiting for the loading icon to finish finding one.

The initializer name of the extension in the admin frontend is incorrectly spelled and doesn't match with the extension ID

actual fof-socialprfile
expected fof-socialprofile

This is not causing any issue. But fixing it might, as it would be a breaking change if any other extension relies on the current name.

I suggest we leave it as-it for now, but if there's ever a major update of our extension, try to fix it at the same time.

The initializer in the forum frontend is spelled as expected and doesn't need changing.

Bug Report

Current Behavior
If night mode is enabled, the icons are black on dark background, making them almost invisible

Steps to Reproduce

1. Enable fof/nightmode
2. Got to user profile
3. Click "Add"
   
4. See problem

Screenshots

Bug Report

Current Behavior
External website icons are not displayed in social icons field

Steps to Reproduce
Go to profile page, enter website link in the social icons field

Expected Behavior
External website icon should be displayed

Screenshots
https://i.ibb.co/NtG1qVj/Schermafbeelding-2021-11-02-230511.png

Environment

• Flarum version: 1.1.1
• Extension version: 1.1.0
• Hosting environment: VPS
• Browser: Chrome, Firefox, Opera latest versions

| flarum-flags                  | v1.1.0  |        |
| flarum-tags                   | v1.1.0  |        |
| flarum-subscriptions          | v1.1.0  |        |
| flarum-approval               | v1.1.0  |        |
| flarum-suspend                | v1.1.0  |        |
| flarum-markdown               | v1.1.0  |        |
| the-turk-nodp                 | 1.0.1   |        |
| sycho-profile-cover           | v1.3.0  |        |
| sycho-move-posts              | v0.1.5  |        |
| fof-socialprofile             | 1.1.0   |        |
| fof-reactions                 | 1.0.2   |        |
| fof-links                     | 1.0.3   |        |
| fof-gamification              | 1.2.0   |        |
| fof-formatting                | 1.0.1   |        |
| fof-follow-tags               | 1.0.2   |        |
| fof-drafts                    | 1.0.3   |        |
| fof-byobu                     | 1.0.1   |        |
| flarum-sticky                 | v1.1.0  |        |
| flarum-statistics             | v1.1.0  |        |
| flarum-nicknames              | v1.1.0  |        |
| flarum-mentions               | v1.1.1  |        |
| flarum-lock                   | v1.1.0  |        |
| flarum-lang-english           | v1.1.0  |        |
| flarum-emoji                  | v1.1.0  |        |
| clarkwinkelmann-author-change | 1.0.2   |        |
| askvortsov-rich-text          | v2.1.0  |   

Additional Context

In edit buttons menu favicons are loaded as they should, but not in the social icons field.

Also reported by other users on Disucss.

When trying to use a mailto:[email protected] link, this fails validation due to the validator checking inputs are urls only.

I believe this should be replaced by a custom validator to allow both url and mailto: links.

Issue reported here

Hi all!

Hope you're having a great new year so far!

Still learning and new to php/laravel, so this may be a dumb question. Any idea what this output means?

Whoops! There was an error..html.zip

Flarum Info:

My flarum is running on Ubuntu with a managed MySQL backend on digital ocean.

Let me know!

Thank you,

Michael Angelo Rivera

Bug Report

Current Behavior
By tampering with the REST API requests, users can save any favicon URL in the database, and it doesn't even have to be a DuckDuckGo favicon URL.

It's also possible to save a favicon URL even when the admin setting for favicons is disabled.

Expected Behavior
Ideally, the DuckDuckGo URL should entirely be computed server-side, and the frontend should just send whether it wants to use the favicon service or not. Not storing the URL in the database would be even better as it would allow switching the favicon service without updating every user record.

But as a compromise to simplify the fix, the validator could also just validate the URL matches the DuckDuckGo favicon endpoint, and optionally that the hostname matches. I don't see how you could abuse changing just the hostname in the favicon URL, because if you want to fake a favicon appearance you can already link to a domain you own with the favicon of your choice.

Environment

• Flarum version: 1.3.1
• Extension version: dev-master as of 2022-06-13

Possible solution(s)
As described in expected behavior.

The simple solution can probably be done with a regular expression in the validator instead of allowing any value for favicon. But the regexp needs to change depending on the value of the favicon setting in the admin.

This plugin creates large white spaces between texts in HTML text.

Hi why is in CSS this code:

.Pages-container {
    max-width: 820px;
    white-space: pre-wrap;
}

I fix it to this, and text is displayed normally

.Pages-container {
    max-width: 820px;
    white-space: normal !important;
}

I don't know if this is the right procedure, but so far it works for me.

Feature Request

On first glance it is nice that this addon automatically fetches the favicons from the linked pages, but when you realize that in fact it just goes to embedd them from the external website and thus enabled user-tracking for which especially Facebook is infamous for, then you wonder if this minor convenience of not having to choose an icon is really worth this trade-off in user privacy.

So sadly for us we can not use this extension as we value user privacy over small conveniences, besides obvious GDPR issues with that "feature".

Describe the solution you'd like

Ideally there would the an admin setting to just turn off this anti-feature and simple let people chose the icons from the locally available fontawesome icons.

Thanks for considering.

All packages use a dash when the name is made up of several words except for Social Profile.

Exemple:
fof/auth-discord
fof/secure-https
fof/user-bio
...

But for some unknown reason:
fof/socialprofile

On your profile, you can execute JavaScript when somebody clicks one of your social links. if you added a social link with any name and have the URL be "javascript:{yourjscodehere]" then that JS will execute when somebody clicks on that link. Luckily, this javascript will not execute on the forum but rather a new page and because no page was specified, most browsers will execute it in about:blank.