friendsofapi / localise.biz Goto Github PK

Hi!

Would you consider releasing a new version?

Thanks!

Greetings,

I have started to add compatibility with PSR17 with usage of guzzlehttp/psr7 2.0.x-dev.

Feel free to check it and use my branch for a new version with PSR17.

https://github.com/zenobio93/localise.biz/tree/2.x

Hi @Nyholm

It looks like your lacking of time for maintaining this repository.
We didn't heard from you since February on #29.

If needed, I can help on this package.

For example, I'll be glad to work on a v2 based on symfony/http-client.
Is it something which is in your plan or should I create a dedicated fork?

Thanks in advance for your answer!

Keys like "submit button" are not supported.
Translation asset is created (its sent in POST body), but when we try to add translation it fails:

Translation.php:62
$response = $this->httpPostRaw(sprintf('/api/translations/%s/%s?key=%s', urlencode($id), $locale, $projectKey), $translation);

this becomes:

/api/translations/some translation key/pl?key=12

Request that is actually beeing sent is directed to:

/api/translations/some

... and that results in an error response from api: "Missing API key"

This might be related to how the http client implementation handles such cases, I used the php-http/curl-client.

PR is on the way.

The composer.json file does not allow PHP 8.x.

refs php-translation/symfony-bundle#113 (comment)

@sagikazarmark Do you have any comments or suggestions on this API client?

It is not feature complete but I believe all best practices from the boilerplate is used.