Option to disable logging to console when syncing/updating data about webext-options-sync HOT 7 CLOSED

Ah yeah because _applyToForm is a static method. You can changed it to be a regular method and change its calls from OptionsSync._applyToForm to this._applyToForm

Also

- _log(method, list = []) {
+ _log(method, ...args) {

And

- this._log("info", ["Current options:", options]);
+ this._log('info', 'Current options:', options);

from webext-options-sync.

Makes sense! It can be added as an option to new OptionSync(key, {logging: false}) so it's shared across all the methods.

from webext-options-sync.

Yeah, that can be done too!

Should I create a PR for this? I have looked at code and I'm guessing it's a simple if (logging === true) check that we need to add before logging any info/warning to the console.

from webext-options-sync.

It's probably best to have an overridable logging function so we don't have to use if every time. Something like:

constructor(options) {
	this.storageName = options.storageName || 'options';
	if (options.logging === false) {
		this._log = () => {};
	}
}
_log() {
	console.log(...arguments);
}

from webext-options-sync.

Yes of course, much neater.

from webext-options-sync.

Hey, I'm having some trouble getting the _log function correctly called from other methods in the class. The constructor and log function:

constructor(options = {}) {
	this.storageName = options.storageName || 'options';
	if (options.logging === false) {
		this._log = () => {};
	}
}
	
_log(method, list = []) {
	console[method](...list);
}

and it should be called like so:

this._log("info", ["Current options:", options]);

However, I'm getting the following TypeError when trying it on an extension of my own locally:

Uncaught (in promise) TypeError: this._log is not a function
    at Function._applyToForm (content.js:188)

I'm guessing it's got to do with the scope of this changing, but I'm not sure.

from webext-options-sync.

Thanks! Please publish to npm too ☺️

from webext-options-sync.