fredmp / cryptocurrency_valuation_spa Goto Github PK

Currently, to perform a deploy we need to keep the dist folder in the repository (removing it from .gitignore). It doesn't seem to be a nice approach to track these generated files.
This solution can be a better option: https://dev.to/jmbejar/how-to-quickly-deploy-a-vuejs-app-to-heroku-5b0f

Instead of requesting all images to the server, it's better to use a file with all SVG images (sprites).

Some components have too much responsibility. Probably part of their code can be extracted to specific components. For example the modal dialog in ValuationSettings.

Token is valid for 1 hour. A new token is provided every time user makes a request. If user is idle for more than 1 hour we should clean up localStorage credentials and:

1 - Send user to Home when idle for more than 5 hours
2 - Send user to Login when idle between 1 and 5 hours

Let's say: when user forget the tab idle for more than 1 hour, login screen is shown. But if user tries to access the site after a long time, home screen is shown.

• When we try to add a new asset it sometimes doesn't work (more often, when it's the first one after opening the page)
• Sometimes the highlight effect is not triggered on the correct asset
• Besides the bug it would be great to keep the recently added asset at the top of the list (until the user clicks to reorder it or re-opens the page)

Menu is broken when screen size is small

Allow the user to register not only the amount but also when a coin is bought or sold and associated costs. That will provide a more accurate overview as well as information such as mean price.
It will be necessary to change the API as well.

It could be used as the root path whether the user is logged or not. If user is not logged it could display news and useful graphs for example. When it's logged it could add more specific information related to the assets and tracked coins of the user.