frankkoch / moodle-qbehaviour_studentquiz Goto Github PK

Hi Frank
as suspected with moodle 3.3 and 3.4 the student quiz is blowing up courses as it tries to load 999 topics to the screen. Plus with no setting in the course settings to reduce the number to something sensible the course just freezes. this is a major bug. You will need to redesign or remove the function of it creating the student compelted quizzes in the 999 section. Please put a warning on your plugin site in moodle. We are busy with roll over for next year and do not have time to fix this ourselves

I am getting the following error when I go into an instance of StudentQuiz.
Error: mdb->get_record() found more than one record!

line 1539 of /lib/dml/moodle_database.php: call to debugging()
line 1499 of /lib/dml/moodle_database.php: call to moodle_database->get_record_sql()
line 1478 of /lib/dml/moodle_database.php: call to moodle_database->get_record_select()
line 92 of /mod/studentquiz/viewlib.php: call to moodle_database->get_record()
line 87 of /mod/studentquiz/viewlib.php: call to studentquiz_view->check_question_category()
line 37 of /mod/studentquiz/view.php: call to studentquiz_view->__construct()

I think it was triggered by importing an xml file that contained categories and it seems that this plugin uses tags for organising questions. When I re-imported without categories it was OK. It might be an idea to have some defensive code that deals with the situation where categories are present.

This style rule causes problems:

https://github.com/frankkoch/moodle-qbehaviour_studentquiz/blob/master/styles.css#L44

div.none, .hidden {
    display: none;
}

In a Moodle plugin, all CSS selectors used should include the plugin name. It is dangerous to change the styling of generic selectors.

For example, in old Moodle themes, the submit button for any form is in a

Most of the CSS here, and in mod_studentquiz look fine. There are just a few rules (not just the one example above) that could usefully be fixed up. Thanks.