franc0is / test-dept Goto Github PK

What steps will reproduce the problem?
1. Use Test Dept
2. Use assert_string_equals with a long string
3.

What is the expected output? 
The strings are equal or not

What do you see instead?
Test dept will only compare strings up to 128 char.

Please provide any additional information below.

Why are you placing this limit on the length of strings. Test dept uses strcmp 
and the 128 char limit is unnecessary.

> What steps will reproduce the problem?

1. Download the attached test case and files
2. type "make test_dept_run"

> What is the expected output? What do you see instead?

Test case segfaults at "bar++;" in foo.c, but the test should pass. If you 
compile it without including the proxy object files (swapping 
foo_using_proxies.o and foo_proxies.o for foo.o), then the test passes 
successfully as expected.

> What version of the product are you using? On what operating system?

Test Dept 0.14 on Ubuntu 11.04 (64 bit).

> Please provide any additional information below.

I can't think of a good use case for mocking external variables (since the test 
case could just use the external variable directly). Maybe switches or proxies 
don't need to be generated for them?

What steps will reproduce the problem?
1. Add -g to compile and link options
2. build tests
3. run gdb on executable
4. put breakpoint on test function
5. run

What is the expected output? What do you see instead?
I expect that the debugger will break at the breakpointed function. Instead the 
test executable completes and exits.

What version of the product are you using? On what operating system?
The latest downloaded yesterday. Fedora 13

Please provide any additional information below.

What steps will reproduce the problem?
1. Download and extract the 0.14.2 source tarchive to a 32-bit FreeBSD system
2. cd test-dept && gmake check

What is the expected output? What do you see instead?
The build fails because it can't find "sym2asm_i386.awk". This is solved with 
"cp src/sym2asm_i686.awk src/sym2asm_i386.awk".

After that, the build fails on the tests in examples/example_project because 
the real foo() and malloc() are called instead of the replacements. I 
investigated and found that sym2repl wasn't printing anything, no matter what 
was given to it. It turns out that the awk command was somehow expanding to 

    awk '{print $NF " " $NF "_test_dept_proxy" }' ""

with the empty string argument apparently causing awk to print nowhere on 
FreeBSD. I deleted the "${SUT_SYMBOLS_FILE}" from sym2repl and "gmake check" 
succeeded afterward. 

Here's a patch that eliminates it, but the issue also goes away if you remove 
the double quotes from the variable expansion in the awk command:

Index: src/sym2repl
===================================================================
--- src/sym2repl    (revision 245)
+++ src/sym2repl    (working copy)
@@ -40,8 +40,4 @@
    ;;
 esac

-if [ "$SUT_SYMBOLS_FILE" != "" ]; then
- [ -f "$SUT_SYMBOLS_FILE" ] || err "no readable file named 
\"$SUT_SYMBOLS_FILE\""
-fi
-
-awk '{print $NF " " $NF "_test_dept_proxy" }' "${SUT_SYMBOLS_FILE}"
+awk '{print $NF " " $NF "_test_dept_proxy" }'