Git Product home page Git Product logo

myportfolio's Introduction

Hi there ๐Ÿ‘‹, I am Salman Ahmad Khan

Typing SVG






Number of People who shared my friendship


โ€ƒโ€ƒโ€ƒโ€ƒโ€ƒโ€ƒโ€ƒโ€ƒโ€ƒโ€ƒโ€ƒโ€ƒโ€ƒโ€ƒ github

My Skill Set

Frontend

React Bootstrap CSS3 HTML5 JavaScript TypeScript Redux Jest

Backend

TypeScript C++ JavaScript MongoDB Node.js Ruby Ruby on Rails

DevOps

Git

๐Ÿ“ž Contact Me

If you're interested in working with me or have any questions, feel free to reach out to me via GitHub, LinkedIn, Facebook, Twitter or visit my portfolio.



github โ€ƒโ€ƒ linkedinโ€ƒโ€ƒ facebookโ€ƒโ€ƒ twitterโ€ƒโ€ƒ website

myportfolio's People

Contributors

fpsapc avatar mukaba avatar xandro2021 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

myportfolio's Issues

๐Ÿž Code not working as expected

๐Ÿž Code not working as expected

Hello @fpsapc you have done a good job, congrats

But I have identified an issue in your code where the code is not working as expected. After debugging, I have determined that the code is not looping through the projects array and adding the HTML elements to the projectsContainer element. I propose you to add a method that will iterate into the projects[] array at line 81 to avoid this error :

image

proposed solution:
at line 81 try this: projects.map((card) => {.

We need to add this line of code back in order for the code to work correctly. ๐Ÿ”ง

Peer-to-peer code reviews

Great Work Salman

  • Local Storage is working fine with no issues.

Other Suggestions:

  • To adjust section overflow I guess you should remove the display from a container in the desktop version and rearrange the items inside.
  • You have done a good job! - Optional suggestion: Try to use dynamic units for larger widths to avoid boxes overflowing the viewport
  • Using fixed units like pixels could cause issues with your project being responsive, try using units like percent, vh, vw etc.

Morning session feedback

  • Use more specific class names: Using more specific class names can make the code more readable and easier to understand. For example, instead of using "footer" as a class name, you could use "site-footer" or "page-footer" to provide more context.
  • Use consistent naming conventions: Make sure to use a consistent naming convention for class names, such as camelCase or kebab-case. This can help make your code more readable and maintainable.
  • Consolidate styles: Consider consolidating styles that are repeated across multiple classes. For example, the "cursor" and "padding" properties could be defined in a single class and applied to multiple elements.
  • Capitalized the first letter when committing.
  • It would be better not to use vh or vw unless there is a good reason.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.