fpavogt / fcmaker Goto Github PK

Hi,

I'm trying to import fcmaker in python 3.6.8, I have made sure to install keyring, but it seems that fcmaker uses a function that no longer exists in this version (I tried keyring.version but apparent;y the module does nto have a version attribute - weird).

Given what I get from help(keyring.util), it does not look like keyring.util.escape exists:

Help on package keyring.util in keyring:

NAME
    keyring.util

PACKAGE CONTENTS
    platform_
    properties

FUNCTIONS
    once(func)
        Decorate func so it's only ever called the first time.
        
        This decorator can ensure that an expensive or non-idempotent function
        will not be expensive on subsequent calls and is idempotent.
        
        >>> func = once(lambda a: a+3)
        >>> func(3)
        6
        >>> func(9)
        6
        >>> func('12')
        6
    
    suppress_exceptions(callables, exceptions=<class 'Exception'>)
        yield the results of calling each element of callables, suppressing
        any indicated exceptions.

FILE
    /home/fste075/.local/lib/python3.6/site-packages/keyring/util/__init__.py

Cheers,
Heloise

Dear Frederic,

We found a strange error on fcmaker that deals with the HTTP package. The full printout of fxmaker shows (see at the bottom for the traceback of the error)

2143401: fetching the OB parameters ...
2143401: creating the finding chart ...
Downloading the SDSSr background image with SkyView ...
WARNING: AstropyDeprecationWarning: The truth value of a Quantity is ambiguous. In the future this will raise a ValueError. [astropy.units.quantity]
Downloading https://skyview.gsfc.nasa.gov/tempspace/fits/skv703270614345.fits
|==========================================| 16M/ 16M (100.00%) 1m13s
Downloading the DSS2 Red background image with SkyView ...
WARNING: AstropyDeprecationWarning: The truth value of a Quantity is ambiguous. In the future this will raise a ValueError. [astropy.units.quantity]
INFO: Auto-setting vmin to -5.850e-02 [aplpy.core]
INFO: Auto-setting vmax to 2.129e-01 [aplpy.core]
INFO: Auto-setting vmin to 5.233e+03 [aplpy.core]
INFO: Auto-setting vmax to 1.066e+04 [aplpy.core]
Querying GAIA DR2 to look for high proper motion stars in the area ...
Traceback (most recent call last):
File "/Users/blabla/anaconda3/envs/py36/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/Users/blabla/anaconda3/envs/py36/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/Users/blabla/anaconda3/envs/py36/lib/python3.6/site-packages/fcmaker/main.py", line 210, in
do_parang = args.do_parang,
File "/Users/blabla/anaconda3/envs/py36/lib/python3.6/site-packages/fcmaker/fcmaker.py", line 240, in make_fc
do_pdf=do_pdf, do_png=do_png)
File "/Users/blabla/anaconda3/envs/py36/lib/python3.6/site-packages/fcmaker/fcmaker_plots.py", line 401, in draw_fc
j = Gaia.cone_search(left_center, right_radius*u.arcsec, verbose=False)
File "/Users/blabla/anaconda3/envs/py36/lib/python3.6/site-packages/astroquery/gaia/core.py", line 408, in cone_search
dump_to_file=dump_to_file)
File "/Users/blabla/anaconda3/envs/py36/lib/python3.6/site-packages/astroquery/gaia/core.py", line 373, in __cone_search
dump_to_file=dump_to_file)
File "/Users/blabla/anaconda3/envs/py36/lib/python3.6/site-packages/astroquery/utils/tap/core.py", line 241, in launch_job
raise requests.exceptions.HTTPError(response.reason)
requests.exceptions.HTTPError: Service Unavailable

As far as we see the file gets downloaded as it can be opened in ds9.

Cheers,

R.

One user reports the following:

I got X-SHOOTER time and used the DSS background images. They were downloaded by fcmaker but then I faced an error: ValueError: could not convert string to float: 'smaller'

It was due to the fact, that the Header line in the fits file contains an extra comment in brackets:
COMMENT Bandpass: 422-965 THz (individual plates have smaller bandpass)

Hi,

I've been trying out the --demo and this happened with XSHOOTER so I thought I'd report it.
Cheers :)

>>> python -m fcmaker --demo --obid 2274416

WARNING: AstropyDeprecationWarning: astropy.extern.six will be removed in 4.0, use the six module directly if it is still needed [astropy.extern.six]
Created TAP+ (v1.0.1) - Connection:
	Host: gea.esac.esa.int
	Use HTTPS: False
	Port: 80
	SSL Port: 443
 
2274416: fetching the OB parameters ...
2274416: creating the finding chart ...
   Downloading the DSS2 Red background image with SkyView ...
Downloading https://skyview.gsfc.nasa.gov/tempspace/fits/skv1477848105399.fits
|==========================================|  16M/ 16M (100.00%)      3m16s
   Querying GAIA DR2 to look for high proper motion stars in the area ...
   Querying UCAC2 via Vizier to look for possible Guide Stars ...
findfont: Font family ['sans-serif'] not found. Falling back to DejaVu Sans.
Traceback (most recent call last):
  File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/fste075/.local/lib/python3.6/site-packages/fcmaker/__main__.py", line 214, in <module>
    do_parang = args.do_parang,
  File "/home/fste075/.local/lib/python3.6/site-packages/fcmaker/fcmaker.py", line 255, in make_fc
    do_pdf=do_pdf, do_png=do_png)
  File "/home/fste075/.local/lib/python3.6/site-packages/fcmaker/fcmaker_plots.py", line 632, in draw_fc
    fig1.savefig(fn_out+'.jpg')
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/figure.py", line 2180, in savefig
    self.canvas.print_figure(fname, **kwargs)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/backend_bases.py", line 2082, in print_figure
    **kwargs)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/backends/backend_agg.py", line 579, in print_jpg
    buf, size = self.print_to_buffer()
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/backends/backend_agg.py", line 535, in print_to_buffer
    FigureCanvasAgg.draw(self)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/backends/backend_agg.py", line 388, in draw
    self.figure.draw(self.renderer)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/artist.py", line 38, in draw_wrapper
    return draw(artist, renderer, *args, **kwargs)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/figure.py", line 1709, in draw
    renderer, self, artists, self.suppressComposite)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/image.py", line 135, in _draw_list_compositing_images
    a.draw(renderer)
  File "/home/fste075/.local/lib/python3.6/site-packages/astropy/visualization/wcsaxes/core.py", line 458, in draw
    super().draw(renderer, inframe=inframe)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/artist.py", line 38, in draw_wrapper
    return draw(artist, renderer, *args, **kwargs)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/axes/_base.py", line 2647, in draw
    mimage._draw_list_compositing_images(renderer, self, artists)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/image.py", line 135, in _draw_list_compositing_images
    a.draw(renderer)
  File "/home/fste075/.local/lib/python3.6/site-packages/astropy/visualization/wcsaxes/core.py", line 49, in draw
    self.axes.draw_wcsaxes(renderer)
  File "/home/fste075/.local/lib/python3.6/site-packages/astropy/visualization/wcsaxes/core.py", line 422, in draw_wcsaxes
    ticks_locs=ticks_locs[coord])
  File "/home/fste075/.local/lib/python3.6/site-packages/astropy/visualization/wcsaxes/coordinate_helpers.py", line 558, in _draw_ticks
    tick_out_size=self.ticks.out_size)
  File "/home/fste075/.local/lib/python3.6/site-packages/astropy/visualization/wcsaxes/ticklabels.py", line 221, in draw
    bb = super().get_window_extent(renderer)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/text.py", line 890, in get_window_extent
    bbox, info, descent = self._get_layout(self._renderer)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/text.py", line 298, in _get_layout
    clean_line, self._fontproperties, ismath=ismath)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/backends/backend_agg.py", line 206, in get_text_width_height_descent
    self.mathtext_parser.parse(s, self.dpi, prop)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/mathtext.py", line 3362, in parse
    font_output = fontset_class(prop, backend)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/mathtext.py", line 671, in __init__
    self._stix_fallback = StixFonts(*args, **kwargs)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/mathtext.py", line 984, in __init__
    fullpath = findfont(name)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/font_manager.py", line 1238, in findfont
    rc_params)
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/font_manager.py", line 1270, in _findfont_cached
    + self.score_size(prop.get_size(), font.size))
  File "/home/fste075/.local/lib/python3.6/site-packages/matplotlib/font_manager.py", line 1151, in score_weight
    w1 = weight1 if isinstance(weight1, Number) else weight_dict[weight1]
KeyError: '500'

Tests on sky show that the parallactic angle is computed correctly, but that it should be offset by 180 deg, to match the orientation of the slit on the UT2 screen.

Hi Frederic,

First of all, thanks for making this tool available! I'm running into an issue that may very well be due to something in my OB but I can't figure out what's wrong. After the message 'fetching the OB parameters...' I get the error pasted below. It seems to be looking for a time somewhere but there shouldn't be one in my OB - it's not a time-critical observation. I tried including a given PA instead of parallactic but that doesn't make a difference. Can you tell me what I might be doing wrong?

Thanks!
Marianne

Traceback (most recent call last):
File "/Users/mheida/software/miniconda2/envs/envpy3/lib/python3.6/site-packages/astropy/coordinates/attributes.py", line 182, in convert_input
out = Time(value)
File "/Users/mheida/software/miniconda2/envs/envpy3/lib/python3.6/site-packages/astropy/time/core.py", line 280, in init
precision, in_subfmt, out_subfmt)
File "/Users/mheida/software/miniconda2/envs/envpy3/lib/python3.6/site-packages/astropy/time/core.py", line 330, in _init_from_vals
precision, in_subfmt, out_subfmt)
File "/Users/mheida/software/miniconda2/envs/envpy3/lib/python3.6/site-packages/astropy/time/core.py", line 374, in _get_time_fmt
raise ValueError('Input values did not match {0}'.format(err_msg))
ValueError: Input values did not match any of the formats where the format keyword is optional ['datetime', 'iso', 'isot', 'yday', 'fits', 'byear_str', 'jyear_str']

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/Users/mheida/software/miniconda2/envs/envpy3/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/Users/mheida/software/miniconda2/envs/envpy3/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/Users/mheida/software/miniconda2/envs/envpy3/lib/python3.6/site-packages/fcmaker/main.py", line 210, in
do_parang = args.do_parang,
File "/Users/mheida/software/miniconda2/envs/envpy3/lib/python3.6/site-packages/fcmaker/fcmaker.py", line 234, in make_fc
fc_params = fcm_id.get_p2fcdata(obID, api)
File "/Users/mheida/software/miniconda2/envs/envpy3/lib/python3.6/site-packages/fcmaker/fcmaker_instrument_dispatch.py", line 494, in get_p2fcdata
distance=100*u.pc,
File "/Users/mheida/software/miniconda2/envs/envpy3/lib/python3.6/site-packages/astropy/coordinates/sky_coordinate.py", line 238, in init
setattr(self, attr, kwargs[attr])
File "/Users/mheida/software/miniconda2/envs/envpy3/lib/python3.6/site-packages/astropy/coordinates/sky_coordinate.py", line 716, in setattr
frame_transform_graph.frame_attributes[attr].get(self)
File "/Users/mheida/software/miniconda2/envs/envpy3/lib/python3.6/site-packages/astropy/coordinates/attributes.py", line 105, in get
out, converted = self.convert_input(out)
File "/Users/mheida/software/miniconda2/envs/envpy3/lib/python3.6/site-packages/astropy/coordinates/attributes.py", line 186, in convert_input
value, err))
ValueError: Invalid time input equinox='2000.00'
Input values did not match any of the formats where the format keyword is optional ['datetime', 'iso', 'isot', 'yday', 'fits', 'byear_str', 'jyear_str']

One user reports the following:

>> python3 -m fcmaker 
.....

   Downloading the DSS2 Red background image with SkyView ...

WARNING: AstropyDeprecationWarning: The truth value of a Quantity is ambiguous. In the future this will raise a ValueError. [astropy.units.quantity]
Traceback (most recent call last):

File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/urllib/request.py", line 1318, in do_open

    encode_chunked=req.has_header('Transfer-encoding'))

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1239, in request

    self._send_request(method, url, body, headers, encode_chunked)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1285, in _send_request

    self.endheaders(body, encode_chunked=encode_chunked)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1234, in endheaders

    self._send_output(message_body, encode_chunked=encode_chunked)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1026, in _send_output

    self.send(msg)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 964, in send

    self.connect()

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1400, in connect

    server_hostname=server_hostname)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/ssl.py", line 407, in wrap_socket

    _context=self, _session=session)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/ssl.py", line 814, in __init__

    self.do_handshake()

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/ssl.py", line 1068, in do_handshake

    self._sslobj.do_handshake()

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/ssl.py", line 689, in do_handshake

    self._sslobj.do_handshake()

ssl.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:841)


During handling of the above exception, another exception occurred:


Traceback (most recent call last):

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 193, in _run_module_as_main

    "__main__", mod_spec)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 85, in _run_code

    exec(code, run_globals)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/fcmaker/__main__.py", line 210, in <module>

    do_parang = args.do_parang,

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/fcmaker/fcmaker.py", line 240, in make_fc

    do_pdf=do_pdf, do_png=do_png)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/fcmaker/fcmaker_plots.py", line 344, in draw_fc

    (fn_bk_image_R, survey_R, bk_lam_R) = get_bk_image('DSS2 Red', None, right_center, right_radius, fc_params)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/fcmaker/fcmaker_plots.py", line 171, in get_bk_image

    pixels='%i' %((fcm_m.bk_radius/fcm_m.bk_pix).to(u.arcsec/u.arcsec).value),

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/astroquery/skyview/core.py", line 207, in get_images

    return [obj.get_fits() for obj in readable_objects]

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/astroquery/skyview/core.py", line 207, in <listcomp>

    return [obj.get_fits() for obj in readable_objects]

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/astroquery/utils/commons.py", line 355, in get_fits

    filedata = self.get_string()

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/astroquery/utils/commons.py", line 419, in get_string

    raise e

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/astroquery/utils/commons.py", line 411, in get_string

    with self._readable_object as f:

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/contextlib.py", line 81, in __enter__

    return next(self.gen)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/astropy/utils/data.py", line 192, in get_readable_fileobj

    timeout=remote_timeout)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/astropy/utils/data.py", line 1088, in download_file

    raise e

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/astropy/utils/data.py", line 1021, in download_file

    with urllib.request.urlopen(remote_url, timeout=timeout) as remote:

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/urllib/request.py", line 223, in urlopen

    return opener.open(url, data, timeout)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/urllib/request.py", line 526, in open

    response = self._open(req, data)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/urllib/request.py", line 544, in _open

    '_open', req)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/urllib/request.py", line 504, in _call_chain

    result = func(*args)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/urllib/request.py", line 1361, in https_open

    context=self._context, check_hostname=self._check_hostname)

  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/urllib/request.py", line 1320, in do_open

    raise URLError(err)

urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:841)>

One users reports "black disks on the finding charts", instead of thin circles for the valid TT star area in MUSE WFM AO. Reason unclear. Proposed test: check if present in jpg, png and pdf.

This ticket is open to keep track of other similar events.

Hi @fpavogt

I can see that FORS I currently not supported. What would be required to it to make it work? Would it be something that a user could almost trivially, or does it require specific knowledge of the instrument?

Hi,
I've installed fcmaker into a conda environment (called test_env36) and the installation worked fine. But when funning fcmaker, e.g., just testing it with 'python -m fcmaker --help' I am getting following error, but I don't know what the problem is or how to fix this. Any help is much appreciated!

(test_env36) bash-3.2$ python -m fcmaker --help
Traceback (most recent call last):
File "/Users/christagall/anaconda2/envs/test_env36/lib/python3.6/runpy.py", line 183, in _run_module_as_main
mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
File "/Users/christagall/anaconda2/envs/test_env36/lib/python3.6/runpy.py", line 142, in _get_module_details
return _get_module_details(pkg_main_name, error)
File "/Users/christagall/anaconda2/envs/test_env36/lib/python3.6/runpy.py", line 109, in _get_module_details
import(pkg_name)
File "/Users/christagall/anaconda2/envs/test_env36/lib/python3.6/site-packages/fcmaker/init.py", line 29, in
from .fcmaker import * # So that users only need to do import fcmaker
File "/Users/christagall/anaconda2/envs/test_env36/lib/python3.6/site-packages/fcmaker/fcmaker.py", line 14, in
from . import fcmaker_instrument_dispatch as fcm_id
File "/Users/christagall/anaconda2/envs/test_env36/lib/python3.6/site-packages/fcmaker/fcmaker_instrument_dispatch.py", line 21, in
from . import fcmaker_xshooter as fcm_xshooter
File "/Users/christagall/anaconda2/envs/test_env36/lib/python3.6/site-packages/fcmaker/fcmaker_xshooter.py", line 8, in
from astroplan import Observer
File "/Users/christagall/anaconda2/envs/test_env36/lib/python3.6/site-packages/astroplan/init.py", line 23, in
from .utils import *
File "/Users/christagall/anaconda2/envs/test_env36/lib/python3.6/site-packages/astroplan/utils.py", line 15, in
from astropy.utils.data import _get_download_cache_locs, CacheMissingWarning
ImportError: cannot import name '_get_download_cache_locs'

I'm on a mac with macOS Mojave version 10.14.1 and I use python 3.6 with

matplotlib 3.0.1 1 conda-forge

installed through Conda.

without setting the backend with import matplotlib; matplotlib.use('TkAgg'), the script crashes with the following error message. The error-message is really obscure, so it does not help me a lot.

2018-11-12 14:18:06.422 python[91048:1938705] -[NSApplication _setup:]: unrecognized selector sent to instance 0x7fbee7bc7350
2018-11-12 14:18:06.426 python[91048:1938705] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSApplication _setup:]: unrecognized selector sent to instance 0x7fbee7bc7350'
*** First throw call stack:
(
0 CoreFoundation 0x00007fff31af8e65 __exceptionPreprocess + 256
1 libobjc.A.dylib 0x00007fff5db53720 objc_exception_throw + 48
2 CoreFoundation 0x00007fff31b7622d -[NSObject(NSObject) __retain_OA] + 0
3 CoreFoundation 0x00007fff31a9a820 forwarding + 1486
4 CoreFoundation 0x00007fff31a9a1c8 _CF_forwarding_prep_0 + 120
5 libtk8.6.dylib 0x000000011cdeb295 TkpInit + 408
6 libtk8.6.dylib 0x000000011cd5b69a Initialize + 2457
7 _tkinter.cpython-36m-darwin.so 0x000000011cbbbda4 Tcl_AppInit + 84
8 _tkinter.cpython-36m-darwin.so 0x000000011cbbba7b _tkinter_create + 1115
9 libpython3.6m.dylib 0x0000000108a9ba1b _PyCFunction_FastCallDict + 491
10 libpython3.6m.dylib 0x0000000108b1f6c7 call_function + 439
11 libpython3.6m.dylib 0x0000000108b1c038 _PyEval_EvalFrameDefault + 25080
12 libpython3.6m.dylib 0x0000000108b2050c _PyEval_EvalCodeWithName + 3436
13 libpython3.6m.dylib 0x0000000108b2122b _PyFunction_FastCallDict + 891
14 libpython3.6m.dylib 0x0000000108a4fa53 _PyObject_FastCallDict + 307
15 libpython3.6m.dylib 0x0000000108a4fb75 _PyObject_Call_Prepend + 149
16 libpython3.6m.dylib 0x0000000108a4f811 PyObject_Call + 97
17 libpython3.6m.dylib 0x0000000108ab3d0d slot_tp_init + 125
18 libpython3.6m.dylib 0x0000000108ab0009 type_call + 313
19 libpython3.6m.dylib 0x0000000108a4fa21 _PyObject_FastCallDict + 257
20 libpython3.6m.dylib 0x0000000108a4fe65 _PyObject_FastCallKeywords + 197
21 libpython3.6m.dylib 0x0000000108b1f5c8 call_function + 184
22 libpython3.6m.dylib 0x0000000108b1c0c8 _PyEval_EvalFrameDefault + 25224
23 libpython3.6m.dylib 0x0000000108b20de8 fast_function + 488
24 libpython3.6m.dylib 0x0000000108b1f6a1 call_function + 401
25 libpython3.6m.dylib 0x0000000108b1c038 _PyEval_EvalFrameDefault + 25080
26 libpython3.6m.dylib 0x0000000108b2050c _PyEval_EvalCodeWithName + 3436
27 libpython3.6m.dylib 0x0000000108b2122b _PyFunction_FastCallDict + 891
28 libpython3.6m.dylib 0x0000000108a4fa53 _PyObject_FastCallDict + 307
29 libpython3.6m.dylib 0x0000000108a4fb75 _PyObject_Call_Prepend + 149
30 libpython3.6m.dylib 0x0000000108a4f811 PyObject_Call + 97
31 libpython3.6m.dylib 0x0000000108b1c294 _PyEval_EvalFrameDefault + 25684
32 libpython3.6m.dylib 0x0000000108b2050c _PyEval_EvalCodeWithName + 3436
33 libpython3.6m.dylib 0x0000000108b20e91 fast_function + 657
34 libpython3.6m.dylib 0x0000000108b1f6a1 call_function + 401
35 libpython3.6m.dylib 0x0000000108b1c038 _PyEval_EvalFrameDefault + 25080
36 libpython3.6m.dylib 0x0000000108b20de8 fast_function + 488
37 libpython3.6m.dylib 0x0000000108b1f6a1 call_function + 401
38 libpython3.6m.dylib 0x0000000108b1c038 _PyEval_EvalFrameDefault + 25080
39 libpython3.6m.dylib 0x0000000108b2050c _PyEval_EvalCodeWithName + 3436
40 libpython3.6m.dylib 0x0000000108b20e91 fast_function + 657
41 libpython3.6m.dylib 0x0000000108b1f6a1 call_function + 401
42 libpython3.6m.dylib 0x0000000108b1c038 _PyEval_EvalFrameDefault + 25080
43 libpython3.6m.dylib 0x0000000108b2050c _PyEval_EvalCodeWithName + 3436
44 libpython3.6m.dylib 0x0000000108b20e91 fast_function + 657
45 libpython3.6m.dylib 0x0000000108b1f6a1 call_function + 401
46 libpython3.6m.dylib 0x0000000108b1c0c8 _PyEval_EvalFrameDefault + 25224
47 libpython3.6m.dylib 0x0000000108b20de8 fast_function + 488
48 libpython3.6m.dylib 0x0000000108b1f6a1 call_function + 401
49 libpython3.6m.dylib 0x0000000108b1c038 _PyEval_EvalFrameDefault + 25080
50 libpython3.6m.dylib 0x0000000108b2050c _PyEval_EvalCodeWithName + 3436
51 libpython3.6m.dylib 0x0000000108b15d74 PyEval_EvalCode + 100
52 libpython3.6m.dylib 0x0000000108b4b841 PyRun_FileExFlags + 209
53 libpython3.6m.dylib 0x0000000108b4b0ee PyRun_SimpleFileExFlags + 846
54 libpython3.6m.dylib 0x0000000108b64ab6 Py_Main + 3526
55 python 0x0000000108688df8 main + 232
56 libdyld.dylib 0x00007fff5ec2208d start + 1
57 ??? 0x0000000000000003 0x0 + 3
)
libc++abi.dylib: terminating with uncaught exception of type NSException
[Finished in 1.9s with exit code -6]

One user reports the following error, for a HAWKI OB on p2:

2059158: fetching the OB parameters ...
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/fcmaker/main.py", line 210, in
do_parang = args.do_parang,
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/fcmaker/fcmaker.py", line 234, in make_fc
fc_params = fcm_id.get_p2fcdata(obID, api)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/fcmaker/fcmaker_instrument_dispatch.py", line 518, in get_p2fcdata
return fcm_hawki.get_p2fcdata_hawki(fc_params, ob, api)
TypeError: get_p2fcdata_hawki() takes 2 positional arguments but 3 were given

Hi Frédéric,

I believe that the XSHOOTER detector_to_sky formulae are inconstent with Figure 41 in user manual.

In version 0.37 they are defined as:

   # Rotate the offsets in the Ra-Dec frame
   ddec = np.sin(np.radians(pa)) * dx + np.cos(np.radians(pa)) * dy
   dra = np.cos(np.radians(pa)) * dx - np.sin(np.radians(pa)) * dy
   
   # Flip the RA axis to increase along East
   dra *= -1.

But according to figure 41, for a PA of ZERO, we should have dra = -dy & ddec = -dx, but the above will result in dra = -dx & ddec = dy

I therefore believe the correct formulae should be:

   # Rotate the offsets in the Ra-Dec frame
   ddec = -1. * np.cos(np.radians(pa)) * dx + np.sin(np.radians(pa)) * dy
   dra = np.sin(np.radians(pa)) * dx + np.cos(np.radians(pa)) * dy
   
   # Flip the RA axis to increase along East
   dra *= -1.

Cheers
John

Sometimes, the SkyView query (for whatever survey) returns an empty list, triggering the above error.

This is not due to the server being down, as the same query was shown to work (at the same time) on a different machine.

The questions then are: why is the return list empty at times ? Can I anticipate and solve this in the code ? Or is this a problem purely on the user-side ?

Please report any similar occurrences below, so that we can try to track down the origin of the bug.

One user reports the following when installing fcmaker via pip:

Installing collected packages: pytz, astroplan, fcmaker
Found existing installation: pytz 2017.2
Cannot uninstall 'pytz'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.