foxford / account Goto Github PK

There is no reason to have myAccountId property since we never update it. The value is a constant.

The only methods that are currently used:

• refreshAccessTokenRequest
• revokeRefreshTokenRequest
• accountRequest

These methods aren't used and may be changed in the future:

• accessTokenRequest
• linkRequest
• unlinkRequest
• authRequest
• isEnabledRequest
• enableRequest
• disableRequest
• removeAccountRequest

It would be better to remove them before the next major release, and adding new adjusted versions as we go.

There is no need to fetch account data on refresh requests since we already have the account id.

AccountId is composite type that consists from:

• AccountLabel is an internal tenant's account identifier that is unique within the specified audience
• Audience may represent oauth2 client id, or tenant id, or environment, etc.

Consider passing both to constructor of Account.

String representation is "{accountLabel}.{audience}".
For instance, accountLabel="12345" and audience="example.org" become "12345.example.org".

Note that for requests to account's profile endpoint both accountId ("12345.example.org") and accountLabel ("12345") may make sense (for multi-audience providers and single-audience providers)
Note that it imply changing keys for objects in underlying storage (localStorage).

Service Workers is now shipped by all major browser vendors
https://caniuse.com/#search=service%20workers
https://jakearchibald.github.io/isserviceworkerready/index.html#moar

It may be used to refresh the access token of the current user.

• There are cases where we already have a refresh token. It would be useful to initialize Account using it.
• Since refresh token often don't have expiration time or lasts longer that access token that may also be helpful through development.

Subj

Consider simplifying implementation of signIn() by returning a promise once before processing any of function arguments

Allow to customize provider endpoints:

• authn_uri, authentication endpoint
  with default value: ${this.base_uri}/authn

• account_uri, account endpoint
  with default value: ${this.base_uri}/accounts

FetchEvent is now shipped by all major browser vendors
https://jakearchibald.github.io/isserviceworkerready/#fetch-event
https://w3c.github.io/ServiceWorker/#fetchevent

It may be used to add "authorization" HTTP header with access token of the current user for specified list of URIs.