foundry376 / mailspring-sync Goto Github PK

Objective

Sent mails are duplicating in Microsoft-based email accounts, one per recipient, plus one created by Mailspring.

Testing Notes

This needs to be tested with Outlook accounts. There are plenty of reporters who can verify the fix (as can I).

Tips

The code responsible for moving mail to sent is in Mailspring-Sync/MailSync/TaskProcessor.cpp:1442-1536. I’m going to dig into a bit, and see if I can figure out what’s going wrong, as it is supposed to prevent duplication of sent messages.

References

https://community.getmailspring.com/t/duplication-of-sent-mail/275

This project apparently depends on some incredibly old versions of various dependencies. Most of them do not seem to have seen any updates since their initial inclusion:

• Openssl 1.1.0f, released in May of 2017. The entire 1.1.0 series has been EOL for four years now, this is especially concerning since it's compiled in as a static library which means that ALL encrypted email traffic goes over this fundamentally insecure library.
• libcurl 7.70.0, released in April of 2020
• nlohman 3.7.0, July 2019.
• icalendarlib didn't have any commits between 2012 and 2022, but the commits in 2022 are not in the local copy so it too clearly hasn't been updated
• sqlitecpp 2.0.0, July 2016. Notably also using the ancient sqlite 3.13.
• stanfordcpplib, circa 2019 as far as I can tell

Moreover, the build system builds with Ubuntu Xenial 16.04 images, and builds with static libs from that distribution. Ubuntu Xenial has been end-of-life since 2021, and those dependencies have been completely unmaintained since then. Example, the shipped version of libxml2 is version 2.9.4 which has had numerous reported vulnerabilities since 2021.

Objective

Sent mails are duplicating in Microsoft-based email accounts, one per recipient, plus one created by Mailspring.

Testing Notes

This needs to be tested with Outlook accounts. There are plenty of reporters who can verify the fix (as can I).

Tips

The code responsible for moving mail to sent is in Mailspring-Sync/MailSync/TaskProcessor.cpp:1442-1536. I’m going to dig into a bit, and see if I can figure out what’s going wrong, as it is supposed to prevent duplication of sent messages.

References

https://community.getmailspring.com/t/duplication-of-sent-mail/275