foundata / roundcube-plugin-identity-from-directory Goto Github PK

$config['identity_from_directory_delete_unmanaged'] is a switch to control if unmanaged identities should be deleted automatically.

It might be the case that some identities should be protected from this automatic cleanup (e.g. created by other plugins) while still having a general purpose cleanup mechanism like this. Implementing something like $config['identity_from_directory_exclude_delete_unmanaged_regex'] would make sense.

It is not obvious how to create usable data-URLs for HTML signatures in Roundcube. An example as addition for inline comments / documentation in config.inc.php.dist for $config['identity_from_directory_signature_template_html'] or the README would be nice.

There are environments with unwanted but still needed email aliases (to be able to receive mails for them). A good example is a company renaming with domain change. The organization might wants that users are not being able to use these old addresses as identity in Roundcube but they are still needed in the directory

If so, there is currently no option to exclude some or all addresses. An array as simple list containing exact matches as well as regular expressions would be nice.

The used library returns a string if there is only one address listed in Active Directory's proxyAddresses and an array if there are multiple. The plugin expects to parse a CSV string for the latter case, but gets an array, resulting in a type error.

This only happens if

1. $config['identity_from_directory_handle_proxyaddresses'] is set to true
2. There is more then one alias address stored in the user's proxyAddresses field.

The email address isused to identify the identity and the plugin makes sure there is an up2date identity (by creating or updating an existing one) for each email address found for the user in LDAP/AD.

Other identities for email addresses not found in LDAP/AD will not be touched. It would be nice to provide an option to automatically delete them.

Current behavior: The main email address from field mapping is used for %email%, %email_url% and %email_html% for every signature template.

Expected behavior: The alias email address is used for %email%, %email_url% and %email_html% for the corresponding signature template.

comparison of the Identity outcome in the RC web UI beside the directory data

The matching of existing addresses is not normalized when ACE and IDN format get returned as two additional addresses by the directory server, even though they are in fact the same.

Example 1:

• IDN: foo@überall.example.com
• ACE: [email protected]

Example 2:

• IDN: bar@überALL.example.com
• ACE: [email protected]

At least the following unwanted behavior of the plugin ff these alias addresses would be returned:

1. Four identities instead of two are getting added
2. The %email% signature template placeholders intended for direct usage in common text are using the ACE form if the given source address was already ACE.

There might be also other issues not detected yet. It makes sense to normalize the emails for search and compare actions to prevent all related issues with ACE/IDN/case-sensitivity (at least in the domain part)