formr / formr Goto Github PK

V1.1
I don't understand why in_array() return false; I changed by isset();
may be a problem with == != === ?

line 311 :

        //if (in_array($key, $this->errors)) {
        if (isset($this->errors[$key])) {
            return true;
        }

line 2362:

<div class='xxx'>IS EMPTY</a>; I add .$this->errors[$name].

        # add div if using inline errors
        if ($this->in_errors($name) && $this->inline_errors) {
//            return '<div class="' . $this->inline_errors_class . '"></div>';
            return '<div class="' . $this->inline_errors_class . '">'.$this->errors[$name].'</div>';
        }

If I have a string in the 5th parameter of text input, and I do something wrong in the form, it screws up the styling.

<div class="row">
<div class="col-md">

<?php
if($ip_wait_secs > 0) {
    $form_disabled='disabled';
} else {
    $form_disabled='autofocus';
}

// Commenting out my workaround here:
//if(($form->in_errors('desired_username'))&&(!$ip_wait_secs > 0)){
    $form_disabled='class="form-control is-invalid" autofocus';
}

echo $form->input_text('desired_username',$fs[0],'','',$form_disabled);

if($ip_wait_secs  > 0){
    $form_disabled='disabled';
} else {
    $form_disabled=null;
}
?>
</div>
<div class="col-md">

My workaround is to include the form-control and is-invalid classes if there is an invalid string input by the user.

Many thanks for an outstanding product and best wishes for continued success!

Composer is still not able to install v1.1.2 it's stuck on 1.1

I've forked formr and tested this locally and got it to work by creating a new tag, v1.1.3, that includes the composer.json file currently on the master branch.

You could also remove the existing tags and then add them back with fixed composer.json files that have the version field omitted, but that seems like more trouble than it's worth. I would just make the new tag and be done with it. Hope this helps!

Hello,

I can see there are many "Form Validation Rules". 👍
I think it may be nice if some of them are also included as HTML attribute (if not in extra arguments string)

Regards.

in function _process_post($data)
I add this code :

        # valid tel
        if ($rule == 'tel')
        {
            $post=trim($post);
            $matches=null;
            if ($post!='' && !preg_match("#^[0-9\.\-\s]*$#us", $post, $matches))
            {
                var_dump($matches);
                if($this->_suppress_validation_errors($data)) {
                    $this->errors[$name] = $data['string'];
                } else {
                    $this->errors[$name] = $label . ' must be a valid phone number';
                }
            }
        }

**Please can you update the github with last corrections (for example : #32

i lost time with this knwon problem :)**

am using below code to upload image is there any way to compress image size `

    $form->upload_dir = 'uploads';
    $form->upload_rename = 'hash';
    $form->upload_accepted_mimes = 'image/jpg,image/jpeg,image/gif,image/png';
    if ($form->submit()) {
        $file = $form->post('file');
        $form->printr($file);
    }
    echo $form->messages();
    echo $form->form_open_multipart();
    echo $form->csrf(1800);
    echo $form->input_upload('file[]', 'Photo 1');
    echo $form->input_submit();
    echo $form->form_close();

`

Hello and thanks again for your great job.

I have a small issue with a real simple code. The auto-repopulation of a multi-select input seams to doesn't work and I need to make it by my own.

Could you have a look on this :

$default_tags = array();
$form = new Formr('bootstrap');

if($form->submit()) {
  $tags = $form->post('tag[]');
  echo "post : ";
  var_dump($tags);
  // The auto-repopulate doesn't work...
  // But if I add this : $default_tags = $tags; the auto repopulate seems to work.
}
else {
  echo "post : -";
  $default_tags = array(12,25);
}
echo "<br>default : ";
var_dump($default_tags);

echo $form->form_open('test','test','');
echo $form->input_select_multiple('tag[]', 'Tag','','tag','multiple="multiple"','',$default_tags,'all_tags'); // all tags = array(1=>"value1",2=>"value2",...)
// when I first load the page ID 12 and 25 are selected.
// if I change, let's say : ID 12 and 23 and I submits,
// the post is well received but there's no ID selected anymore.

echo $form->input_submit('submitSave', '', 'save', 'submitSave', 'class="btn btn-outline-primary"');
echo $form->form_close();

Thanks a lot,

titib

Hi Tim,

a radio button using 'value' => 0, 'selected' => 0does not return the checked option. Strings '0' also do not work. Checkboxes not tested.

Nils

I would like to use Formr for the Bootstrap 4 form generation, but it's 2019 and I'm not adding unversioned dependencies to my app. Would you accept a pull request to setup the library for Composer? You would need to create the account at Packagist.

Hi,

if I create a new checkbox like this

// hint: input_checkbox($data, $label = '', $value = '', $id = '', $string = '', $inline = '', $selected = '')
echo $form->input_checkbox("chkReverse", "Reverse-Charge", "1", "chkReverse");`

the produced code looks like this:

<label for="1">
	<input type="checkbox" name="txtReverse" id="1" value="1"> Reverse-Charge
</label>

$data and $id are set to "chkReverse", but the $id is ignored. Also, the label surrounds the tag instead to become closed before.

All other inputs generate code like this (which is okay):

<label for="">VAT Amount</label> 
<input type="number" name="txtVAT" id="txtVAT" class="input" style="width: 60px;">

I expect the above example to produce code like this:

<label for="">Reverse-Charge</label> 
<input type="checkbox" name="txtReverse" id="txtReverse" value="1">

I've come across an issue with add_to_errors and in_errors_if.

In my code, I'm doing my own validation process. When I find a field that hasn't validated properly, I use add_to_errors to put it in the errors array. After I add all the failed fields I have the system doing a var_dump on $form->errors() to make sure they are in there, and it correctly returns the list.

In my form, I'm using in_errors_if to print out a message if the field is in the errors array. However, in_errors_if never returns anything. For example I have the following:

$output .= $form->input_text('lname', "Last Name:");
$output .= $form->in_errors_if('lname', 'Please enter the student\'s last name');
$output .= $form->input_date('dob', "Date of Birth:");
$output .= $form->in_errors_if('dob', 'Please enter the student\'s date of birth');

But even when lname and dob are both added using add_to_errors, the in_errors_if never triggers.

I also tried using if ($form->in_errors('dob')) { blah } but that never returns true either.

Am I missing something or is this a bug?

Following your tutorial and have added the inline checkboxes, unfortunately they are not displayed inline and the label is repeated twice and when I submit any selected values are lost (everything else works).

echo $form->input_checkbox_inline('hobbies[]','Fishing','fishing','fishing'); echo $form->input_checkbox_inline('hobbies[]','Hiking','hiking','hiking'); echo $form->input_checkbox_inline('hobbies[]','Camping','camping','camping'); echo $form->input_checkbox_inline('hobbies[]','Swimming','swimming','swimming');

  <input type="checkbox" name="hobbies[]" id="fishing" value="fishing" class="form-check-input"> <label for="fishing">Fishing   Fishing   </label>   </div>       <div id="_hiking" class="form-check form-check-inline">   <input type="checkbox" name="hobbies[]" id="hiking" value="hiking" class="form-check-input"> <label for="hiking">Hiking   Hiking   </label>   </div>       <div id="_camping" class="form-check form-check-inline">   <input type="checkbox" name="hobbies[]" id="camping" value="camping" class="form-check-input"> <label for="camping">Camping   Camping   </label>   </div>       <div id="_swimming" class="form-check form-check-inline">   <input type="checkbox" name="hobbies[]" id="swimming" value="swimming" class="form-check-input"> <label for="swimming">Swimming   Swimming   </label>   </div>

radio inline has the same issue

If I change the array hobbies[] to say hobbie then the select is preserved on submit and the label only appears once, appears to be something to do with arrays?

The data is being posted and I can display it in the form with print_r

[hobbies] => Array ( [0] => hiking ) [submit] => Submit

To get rid of bold had to override with form-check-inline not checkbox-inline as per docs/tutorial

PHP 7.2.11

When I do this code (on PHP 7.3):

$output .= $form->input_checkbox('agree','I Agree','agree','agreeID');

I get this output:

<div id="_agreeID" class="checkbox">
	<label class="control-label" for="agreeID">I Agree
		<input type="checkbox" name="agree" id="agreeID" value="agree">I Agree
	</label>
</div>

As you can see it's adding the words "I Agree" twice. In the browser this just gives me the check box and "I Agree I Agree". Is there some way to stop the duplicate text from appearing?

Seems custom error message (see below) is never displayed on

$form->post('email','Email|Please enter your email address','valid_email');

$form->error_message()

Thank you for that helpfull tool !

Is this compatible with PHP 7+?

hi,
i am trying to get radio buttons displayed inline, but unfortunately i get a warning message after each radio button called "Please enter a value for the radio: ". If this message is removed all radios are displayed inline.
How can I remove this warning or get it displayed at the end of the radio-group?

echo $form->input_radio_inline('meal','all'); echo $form->input_radio_inline('meal','vegetarian'); echo $form->input_radio_inline('meal','vegan'); echo $form->input_radio_inline('meal','fruits'); echo $form->input_radio_inline('meal','nothing');

regards,
andre

$select_element = [
"name" => "style_id",
"id" => "form_element_1",
"label" => "Style ID",
"options" => [
1 => "Abstract Expressionism",
2 => "American Realism",
3 => "Baroque",
4 => "Cubism"
],
"selected" => 2,
"value" => ''
];

echo $form->input_select( $select_element );

The following code, it won't display the value

$value = '0';
$form->input_text('foo', '', $value, 'foo');

The same happens to the other attributes like $label, $id.
Having a $label='0' is rare but $value='0' is common, and I also had problems $id='0' that gives an error that an id is required.

I checked the formr code, and the problem is due of checks:

• if(empty($var))
• if(!empty($var))
• if($var)

unfortunately, in php empty('0') === true, making these forms of checking for empty useless in this case.
a simple solution, is to rename all:

• empty( with empty_(
• if\((!?)(\$\w+)\) with if($1empty_($2))

and write a empty_ function that handles the '0' case.
I did that myself, unfortunately, I can't disclose due copyrights issues.

When moving one of my sites from local environment to a staging server I get a warning when uploading a file. The file IS uploaded. My code is extacly the same. One difference is that the local site runs PHP 7.1.32 and the staging PHP 7.2.

Hello,

could you include an option to whether create a label for the form inputs?

For my needs i did the following:

in class Formr add class global variable

public $generate_labels = false;

then change the class constructor to

function __construct($wrapper = '', $generate_labels = false) {
$this->generate_labels = $generate_labels;
...
}

then in function label add this just before the closing bracket

    if ($this->generate_labels) {
        return $this->_create_label($data);
    }

Hello!

I am using this lib and I find a potential bug. I print a form as the documentation expains, but send the data with ajax js. The server processes it and sends back the same form, now filled with the entered data and js overrides the sended form with the filled one got back. The problem, that if I do not refresh the page, but modify something with php between sending the data and saving to the db, the lib gives back the data entered and not the actual one in the db (and modified by php before saving). Everything is working,, db data is ok, the lib is called with exactly the same paramters except value, but no change. If I refresh the page, the right data is shown from the db.
If I echo an input manually with the same parameters (and value), everything is working, actual db content is shown regardless the typed ones.
The $form is opened and closed in the same script, so in theory, it should not exist after saving and a new object is created for reproducing the form with the database data.
Reprinted form is called exatly like the first print, not like this:
<input type="text" name="fname" value="<?php echo $form->value('fname'); ?>">

First Tim, let me tell you how happy I am to have found Formr. I just started using it for Wordpress and it works exactly they way I wanted! Great job, and the tutorial videos are perfect!

Now to a minor issue: I noticed that when using the rule 'allow_html', this rule must come last if there are several rules (such as also checking the max_length). If not the html tags will be stripped. You could either fix this or just spell it out in the documentation.

Hi Tim,
Thanks again for the excellent Formr!
I have a small problem with the value parameter for input_submit.

I have the following in my code:
$form->input_submit('submit', '', 'Enregister', 'submit_id', 'class="btn btn-success"');

I would expect to see 'Enregistrer' as the the value attribute (and displayed as the text inside the button), but this results in:

<input type="submit" name="submit" value="Submit" id="submit_id" class="btn btn btn-success">

So I can't change the submit button's text independently of the button name. Would be nice if you could fix it.

Cheers,
-- christer

Hello,

I'm trying to access my database inside my.dropdowns. For this I use Medoo class . I have an external config file like this:

require_once('Medoo.php');
use Medoo\Medoo;
$database = new Medoo([
	'database_type' => 'mysql',
	'database_name' => 'database',
	'server' => 'localhost',
	'username' => 'root',
	'password' => 'root',
	'charset' => 'utf8',
	'prefix' => 'db_'
]);

I tried something like this and it work but it's really messy (especially the fact I need to include the config file multiple times)... Do you have any idea how to do in a better way?

class MyDropdowns {
    public static function all_tags()
    {
        require('../lib/config.php');
        $content =  $database->select('content', ['id','title'],['ORDER'=>['title'=>'ASC']]);
        foreach($content as $t) {
            $return[$t['id']] = $t['title'];
        }
        return $return;
    }
}

Thanks

titib

Hello,

I get key/text pairs from a remote database I don't own (so I cannot just change the keys...) with keys being integers.

Now, here's my issue, with the following 3 pairs:

// labels are changed, but the keys are the same
$pairs = arrayr(
    0 => "foo",
    1 => "bar",
    3 => "baz",
);
// then let's create a simple drop down menu with it
$form->input_select('pairs', '', '', "choose", $pairs);

...the result was strange as "foo" was automatically defaulted instead of "choose"

Later, I've been told they can be combined and change my code this way

foreach ($pairs as $v => $l) {
    $form->input_select('pairs[]', $l, $v, "pairs_$v");
}

Now I have that error/red message: "Please enter a value for the checkbox: pairs[]"

For me, it's a bug because zero is a value and it shouldn't behave as if an true empty string or undefined/unset variable is passed.

I just added the following validation statement:

$form->validate('firstname, lastname, email, phone, appointment_date');

which resulted in the following error message in the browser:

Fatal error: Uncaught Error: Call to undefined method Formr::validate() in ...

$form is defined and refers to a submitted form, since I pick up post parameters without any problem.

I quickly scanned the Formr source code and didn't see any definition of validate function. Does it still exist?

echo $form->input_select_multiple('family_status', "family_status:",'','','','','', 'family_status');

First, really loving this script! Makes it so much easier. Had one issue though, when doing validation I want to be able to supress any errors that may come up except the custom one I set. For example:

$form->post('lp','Password|Invalid Login/Password','sanitize_string|alpha_dash|min_length[6]');

I do not want to tip hackers to any requirements for the password field. No matter what, if there was any validation issues, I want it to show my custom error message of Invalid Login/Password. Now this works if it doesnt meant the requirements, except min_length. If it doesnt meant that, it gives an error message of:

Password must be at least 6 characters

If I pass it a custom error message, IMO the error above shouldnt show up, only the custom error message I am passing. Is there anyway you can change this or give me the option to suppress the errors from the validation rules and only show my custom error message?

For my latest project I do not use Bootstrap, and I found that the alerts ("... saved") do not work. They show up, but can not be closed. Is there an easy javascript+CSS way to handle this without bootstrap?

I tried following in fast_form
'hidden1' => [ 'name'=> 'email', 'id'=> 'email', 'value'=> 'test'], 'hidden2' => [ 'name'=> 'email2', 'id'=> 'email2', 'value'=> 'test2'],

Hello!

Require indicator is a useful features, but it only works when form instance is not created with Bootstrap. Once you set Bootstrap, everything looks fine, but there is no asterix after label names. I tried to fix it in wrappers.php, but no luck.
Could someone give some help?
Thank you.

i create input group with below group code in bootstrap is there any way to create input group in formr

<div class="input-group mb-3">
  <div class="input-group-prepend">
    <span class="input-group-text" id="basic-addon1">@</span>
 </div>
  <input type="text" class="form-control" placeholder="Username" aria-label="Username" aria-describedby="basic-addon1">
</div>

Cannot install v1.1.2 with Composer only v1.1

I think the version number needs to be omitted in composer.json. Right now the version is set at 1.1 in composer.json.

Found this on Packagist.org:
The easiest way to manage versioning is to just omit the version field from the composer.json file. The version numbers will then be parsed from the tag and branch names.

Just wondering if there is a way I can specify the type field for the function input_button. Right now it defaults to type="button", but I want to be able to specify the button as type="submit". Ending result:

<button type="submit" class="btn btn-primary btn-block">Apply Filters</button>

Otherwise I would have to use jquery onclick command to submit the form. I prefer a button instead of a normal submit button because I dont need to specify a value for a button and it works differently in bootstrap for me with regards to styling in bootstrap 4.

Whenever I try to submit my form I get the following error

Undefined index: token

#0 lib/formr/class.formr.php(283): Core\Error::errorHandler()
#1 App/Controllers/AuthController.php(121): Formr->submit()

Controller File

 $form = new \Formr('bootstrap');

if ($form->submit()) {
}

View File

{!! $form->form_open('', 'loginForm', Site::url('login'), 'post', 'class="form"') !!}

                {!! $form->csrf() !!}

                <div class="form-fields-split">
                    {!! $form->input_text('username', 'Username <span>*</span>') !!}
                    {!! $form->input_password('password', 'Password <span>*</span>') !!}
                </div>

                <button type="submit" class="g-recaptcha" data-sitekey="{{ env('RECAPTCHA_KEY') }}" data-callback='onSubmit'>Login</button>

                {!! $form->form_close() !!}

There a problem if selected item is in session values. There is no code for this case.

Besides, I had another problem, i don't use === because we need to be tolerant with keys.
All the data stored in $ _POST are of type string.
But if the keys used when calling input_select() are of type integer or if a user set a value in $_Session, you may have a problem.

example :

$test = array(
            "0"=>"-",
            "1"=>"xxx", );

$test = array(
            0=>"-",
            1=>"xxx", );

echo $this->input_select('interet', 'xxxxxx','','','','','', $test);

here my code :

# user has entered a value in the 'values' argument
                    if ($this->session_values && $this->session && !empty($_SESSION[$this->session][$data['name']]) && $_SESSION[$this->session][$data['name']] == $key) {
                        $return .= $this->_t(2) . '<option value="' . $key . '" selected="selected">' . $value . '</option>' . $this->_nl(1);
                    }
                    elseif (!isset($_POST[$data['name']]) && $data['value'] == $key) {
//                    if (!isset($_POST[$data['name']]) && $data['value'] === $key) {
                        $return .= $this->_t(2) . '<option value="' . $key . '" selected="selected">' . $value . '</option>' . $this->_nl(1);
                    } else {
                        $return .= $this->_t(2) . '<option value="' . $key . '">' . $value . '</option>' . $this->_nl(1);
                    }

• if this is set: $form->error_message('Invalid Username')
• then function $form->messages('<div class="alert alert_error"><div class="alert_icon icon-alert"></div><div class="alert_wrapper">','</div></div>') does not wrap the error message nicely, like it does for validation messages.

Hi,
First of all, I want to say thanks for your wonderful work her.
I have a problem, types are not allowed of files ara uploaded despite the mimes,
I used $form->upload_accepted_mimes = 'images'; and getting the alert "Oops! The file was not uploaded because it is an unsupported mime type". But when I checked it entered the folder.

how can I prevent it by formr?

Thanks,
Golan

<?php  
require_once 'Formr/class.formr.php'

?>

<html lang="en">
<head>
    <!-- Required meta tags -->
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
    
     <title>test</title>
     
</head>
<body>
       
<!-- Team -->
<section id="team" class="">
    
    
<div class="container">
        

<?php
// include the Formr class


// instantiate Formr
$form = new Formr();

// set our upload directory
$form->upload_dir = 'uploads';

// rename our upload with a 32-character hash
$form->upload_rename = 'hash';

// only allow images to be uploaded
$form->upload_accepted_mimes = 'images';

// resize the upload
$form->upload_resize = array(
	'thumbnail'	=> '100,100,tn_,/www/formr/uploads/thumbnails/,90'
);

// check if the form has been submitted
if($form->submit()) {
	
	// process the upload and put it into an array
	$file = $form->post('file');

    // printr() the array to see its keys/values
    $form->printr($file);
}

// always print Formr's messages!
echo $form->messages();

// open our form element
echo $form->form_open_multipart();

// add our file element
echo $form->input_upload('file');

// submit button
echo $form->input_submit();

//close the form
echo $form->form_close();

?>
</div>
  
</body>

</html>

If a form fails validation Formr automatically remembers and redisplays all the form fields.

It appears there is a bug as any field with a value of 0 (zero) on submission is redisplayed with no value (value is not defined on the input field), All other fields redisplay correctly.

When inline errors are turned on ($form->inline_errors = true;) and an input field is incorrect, the splash message displays but the field is not highlighted.

turn on php error reporting

try this script here:
=> http://formr.github.io/upload-files/#a-complete-example

you will get Warning: imagejpeg(/www/formr/uploads/thumbnails//tn_20M3N2Qr1MRs0zmwkl7Yq4Q9hjZR818W.jpg): failed to open stream: No such file or directory in C:\wamp64\www\httpformr\class.formr.php on line 1368

see this double trailing slashes => '/www/formr/uploads/thumbnails//'?

Why there is double trailing slashes?

Hi Tim,

if you enter a form by a post from another form, e.g. a login, the 'selected' values are completely ignored:

2563 # check the element on initial form load
2564            if (!$_POST) {

I think you should rather ask for the specific form element:

2564            if (!isset($_POST[$data['name']])) {

Nils

I still think there are issues. Please see the below code and the produced output:

$form = new Formr();
echo $form->form_open("","","?p=customer");
echo $form->input_checkbox("chkReverse", "Reverse-Charge", "1");
echo $form->input_text("txtVAT", "VAT Amount");
echo $form->form_close();

Producing this output:

<form action="?p=customer" method="post" accept-charset="utf-8">

<label for="1">
	<input type="checkbox" name="chkReverse" id="1" value="1"> Reverse-Charge
</label>

<label for="">VAT Amount</label> 
<input type="text" name="txtVAT" class="input" id="txtVAT">

</form>

Three problems here:

1. The checkbox label is surrounding and the text label is on top. Inconsistent. Bad for CSS.
2. The checkbox is not using the name as id. Instead, it uses the value. Bug?
3. The text label does not set the for attribute to the used id. Bug?

I'm looking for a multi-select checkbox when every select will open an extra list limited One choice

Thanks

I would like to use Formr with the upcoming Bootstrap 4

Hello, and thank you for you great job!
I have a problem with the method input_text() re-populate value action. I have a very simple form, with only one input and one submit, used for create and modify content.
Here is a small version of my script which produce the problem.
When you access it with ?u=1 (update), you can see the text to update... but when you submit, it still shown. Same with adding.
And the stranger things is after submitted, the value for input_text and input_submit does not follow the same rule... (see the placeholder and submit value).

I don't know if I'm clear but I hope the script is :-)

Thanks again.

titib

<?php
require_once('lib/config.php');

$update = $_GET['u'];
if($update == '1') {
  // get data from database...
  $tag_data = 'content to modify';
}

$form = new Formr('bootstrap');
if($form->submit()){
  $update = '0';
  if($form->post('submit') == 'Modifier') {
    // update in database
  }
  else {
    // add in Database
  }
}

if($update == '1') {
  $form_placeholder = 'Name to modify';
  $form_tag = $tag_data;
  $form_submit = 'Modify';
}
else {
  $form_placeholder = 'Name to add';
  $form_tag = '';
  $form_submit = 'Add';
  $update = '0';
}
echo 'update = '.$update;

echo $form->messages();
echo $form->form_open();
echo $form->input_text('tag','',$form_tag,'tag','placeholder="'.$form_placeholder.'" class="form-control"');
echo $form->input_submit('submit','',$form_submit,'submit','class="btn btn btn-outline-primary"');
echo $form->form_close();

When I tried to install with Composer I've got the following error:

Could not find a version of package xlad/formr matching your minimum-stability (stable). Require it with an explicit version constraint allowing its desired stability.

any suggestion?

I have 2 forms on the same page. When I submit 1 the other also is being submitted. I check with below condition.
`
$form1 = new Formr('bootstrap');
$form2 = new Formr('bootstrap');

if($form1->submitted())
{
}

if($form2->submitted())
{
}

`

The example does not include the "label" variable that appears to be required.
Otherwise a very helpful library.