Comments (9)
@SurpSG I can confirm the fix works fine for my workspace. Thanks!
Can you link the commit that fixed it?
from diff-coverage-gradle.
Thanks!
we will make a new release with the fix soon.
In v0.7.2 we've updated kotlin plugin to v1.4.32 but Gradle 6.7.1 has embedded kotlin 1.3.72
Adding of
diff-coverage-gradle/build.gradle
Line 54 in e4bb5b6
fixed the issue
compileKotlin {
kotlinOptions.jvmTarget = '1.8'
kotlinOptions.apiVersion = '1.3' // <----------
}
from diff-coverage-gradle.
Hi @locomike
Could you please provide the next info:
- what gradle version do you use?
- do you use kotlin gradle dsl or groovy?
from diff-coverage-gradle.
This is my ./gradlew --version
output:
./gradlew --version
------------------------------------------------------------
Gradle 6.7.1
------------------------------------------------------------
Build time: 2020-11-16 17:09:24 UTC
Revision: 2972ff02f3210d2ceed2f1ea880f026acfbab5c0
Kotlin: 1.3.72
Groovy: 2.5.12
Ant: Apache Ant(TM) version 1.10.8 compiled on May 10 2020
JVM: 11.0.11 (Azul Systems, Inc. 11.0.11+9-LTS)
OS: Mac OS X 11.4 aarch64
I'm using Groovy DSL.
I guess the problem could be tha tI'm using Kotlin 1.3.72 and I need at least 1.4. I will try and figure out how to update that.
from diff-coverage-gradle.
@locomike try to downgrade Diff Coverage from v0.7.2 to v0.7.1, please.
Kotlin v1.3.72 is used in Diff Coverage 0.7.1
from diff-coverage-gradle.
@SurpSG Thanks, that did it!
Is there a particular version of Gradle I need to migrate to to have v0.7.2 working? I get that the issue here is the embedded Kotlin inside Gradle, and not my Kotlin dependency specified in Gradle, which is above v4.
from diff-coverage-gradle.
@locomike, nice to hear that!
You could migrate to Gradle v7 to be able to use Diff Coverage v0.7.2, but it doesn't make any sense. Only support of Gradle v7 was added to v0.7.2
As you mentioned above, your Gradle wrapper has embedded Kotlin v1.3.72 but the latest Diff Coverage was compiled with Kotlin v1.4.32
Seems, it's just Kotlin compatibility issue. We will fix the issue in further Diff Coverage releases.
Thanks for reporting the issue!
from diff-coverage-gradle.
@locomike
Could you please check the fix?
classpath 'com.github.form-com.diff-coverage-gradle:diff-coverage:migrate-to-gradle-7-SNAPSHOT'
Change version from 0.7.x
-> migrate-to-gradle-7-SNAPSHOT
from diff-coverage-gradle.
Fixed in https://github.com/form-com/diff-coverage-gradle/releases/tag/0.8.0
from diff-coverage-gradle.
Related Issues (20)
- File Path is not support on UTF8 chars HOT 6
- Tasks failed with FileNotFoundException HOT 5
- example for diffCoverageReport config for kotlin gradle script? HOT 3
- Possible to use with GitLab Violation reporter? HOT 2
- Incorrect git diff file generated by plugin HOT 6
- Cannot include the plugin in gradle, cannot find plugin id HOT 7
- Gradle 7.4 - Execution optimizations have been disabled for task ':diffCoverage' HOT 3
- java.lang.ClassCastException HOT 1
- 'diffCoverageReport.classesDirs' file collection is empty. HOT 20
- Consider adding support for Configuration Cache HOT 4
- Log4J Dependency has security vulnerability HOT 1
- False Negative on Code Coverage for Blank Lines and Comments added to Source file under test HOT 5
- Wrong class file distinguish when two classes having same package and name HOT 5
- diffCoverage gives html report with "No class files specified." HOT 3
- How to setup in a multi-module project? HOT 3
- Diffcoverage fails with Empty File Collection if Clean is used HOT 5
- Adding exclusions setting HOT 4
- README gives incorrect default report directory HOT 1
- diffSource.git.compareWith ignores uncommitted files HOT 8
- [feature request] support the coverage to 2 decimal HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from diff-coverage-gradle.