Git Product home page Git Product logo

foundryvtt-forien-unidentified-items's People

Contributors

drdwing avatar forien avatar p4535992 avatar rinnocenti avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

foundryvtt-forien-unidentified-items's Issues

[Can't use "mystify as"]

Module Version: v0.4.1

Describe the bug
When I use the "mystify as" option and drag a item on the drag in box, the item not become selected.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'misity as'
  2. Drag any item
  3. Nothing happens

Expected behavior
The item appears on the box and can be used to mystify.

Foundry Version:
9.269
Game System:
D&D 1.6.0

Duplication of other Modules in Item Menu

Hi,

Big fan of the module been a user of Forien's modules for the last 4 months. Ever since the big foundry update I haven't been able to use unidentified items because of how it doubles magic items and better rolls in the item menu. (see example below)

image

I confirmed that some how unidentified items is doing it through a process of disabling modules while leaving all others enabled.

For now I will leave it disabled but I thought I should report it, I love the quest log module and use it every session. Big thanks!!!

Partially identify an Item

Hey there~
I don't know if it's already possible (I wouldn't know how) but it would be awesome if I could identify the obvious properties of an item but some of them are hidden until you use identify or a higher ability check.

Example:
You found a mysterious potion. You don't know what it does so you sniff it first or taste it. The potion has two effects: healing and advantage on dex checks and saving throws.
You feel the heal after you drink it and something other but can't figure it out what it is. So you know one effect but don't know the other one.

embedded items are bugging after you identify once

Module Version: v0.2.3

Describe the bug
embedded items are bugging after you mistify, identify once

To Reproduce
have an item in an actor.
mistify it
identify it.
the incorrect options in the item tab bar will show (peek when the item is already revealed, see screenshot)

Screenshots
image

Browser:
native client

Foundry Version:
0.6.5
Game System:

[BUG] Window bar not updating when mystifying/identifiying an item

Module Version: v0.2.5

Describe the bug
Whenever a item is mystified or identified, the window bar will still display the same actions, even if some of those actions don't make sense. Any extra actions are also not added, which is not a huge problem but still a bit inconvenient.

To Reproduce
Steps to reproduce the behavior:

  1. Open a character sheet
  2. Add an item
  3. Open the item's item sheet
  4. Click on "Mystify" in the window bar
  5. Note that the window bar does not add an option to peek or identify
  6. Close the item sheet
  7. Reopen the item sheet
  8. Identify the item
  9. Note that the window bar still allows you to identify or peek

Expected behavior
Whenever a item is mystified, the window bar should add the options of identifying and peeking, whilst still keeping the mystify option for multilayered mystification.
Whenever the item is identified to it's original form, the peek and identify options should no longer be there.

Screenshots
image
image

Browser:
Brave 1.18.70 (Chromium 87.0.4280.101)

Foundry Version:
0.7.8

Game System:
DnD5e 1.2.0

[BUG] Cannot GET /modules/forien-unidentified-items/styles/style.css.map

Module Version: v0.3.17

Describe the bug
A 404 message is shown on the console for the following resource: /modules/forien-unidentified-items/styles/style.css.map

To Reproduce
Steps to reproduce the behavior:

  1. Open a World with module enabled
  2. Check browser's console log
  3. See error

Expected behavior
No error shown. File present if expected?

Screenshots
n/a

Browser:

  • Chrome

Foundry Version: 0.8.9

Game System: dnd5e 1.5.5

Additional context

Cannot GET /modules/forien-unidentified-items/styles/style.css.map

Tooltip/pop over of original name in item list

I have a lot of mystified items ready to give to players that appear to be normal items while mystified but i have to peek at each one to figure out which is which.
It would be very helpful to be able to just mouse over a mystified item (as GM) in the item list and see the original name, perhaps in a pop-over/tooltip?

Allow advanced mystify options directly in the item sheet

Currently the only way to access the advanced mystify options is by right-clicking on an item in the items sidebar. This does not work so well with items directly inserted from a compendium to e.g. an actor sheet. There the only option currently available is the standard mystify which overrides all item-properties including text, image, name, ...

All Items in All Characters Inventory Unidentified

After a recent update, every item on my character's inventory has become Unidentified.

2021-01-04 22_22_09-Foundry Virtual Tabletop • A Standalone Virtual Tabletop Application and 9 more

Every character is like this now and all the items need to identified one-by-one. I uninstalled the Mod and they are still unidentified.

Respect Folders While Mystifying in Item Directory

Currently, if you mystify an item within a folder in the Item Directory, the mystified item appears in the parent Item Directory folder. It would be helpful if the mystified item was in the same folder as the original, identified item.

Nice module, thanks.

[BUG] - data loss when identifying stacked items

Module Version: v0.2.5

Describe the bug

When identifying a stack of mystified items, the quantity of items is lost. I.e. A stack of 5 mystified potions of healing, when identified, becomes only 1 potion.

I'm also using Loot Sheet NPC 5e, individually looting unique mystified items (can be a mix of item types - potions, equipment, etc.) causes them to stack in the player inventory. Identifying the item stack also results in the above bug with only one item being recovered from the identify process

To Reproduce
Create a mystified item and place it into an actors inventory. Change the stack size and then identify.

With Loot Sheet NPC 5e, loot individual items (not loot all). Identifying stack.

Expected behavior

stacked mystified items shouldn't lose the quantity data
unique mystified items shouldn't be able to stack

Browser:
Chrome

Foundry Version:
0.7.9
Game System:
DnD5e 1.2.4

Additional context
Loot Sheet NPC 5e version 2.5.1

Mystified Items Lose Their DAE Effects While Mystified

Module Version: v0.2.3

Describe the bug
Not really sure if it's a bug or feature request. But basically, when using DAE, the effects don't transfer over on mystify. So I have to mystify an object, then go into the object to re-add their particular affect. When I demystify it, the effect from the original is there/back.

To Reproduce
Steps to reproduce the behavior:

  1. In FoundryVTT as admin, open the items tab and then open an item
  2. Click the DAE tab on the items header and review the effect
  3. If there's no effect, create an effect and save
  4. Click the Mystify option in the items header
  5. Open mystified item
  6. Click the DAE tab on the items header and review the effect
  7. Note that the DAE effect is missing or no longer there
  8. Close DAE window
  9. Identify item
  10. Click the DAE tab on the items header and review the effect
  11. Note that it is once again there

Expected behavior
I would expect the DAE effect to be on the mystified item as well as the original item

Browser:
Chrome

Foundry Version:
0.7.9

Game System:
DnD5e - Fifth Edition System 1.2.4

Additional context
Dynamic effects using Active Effects 0.2.52

[BUG] Mystified items added to a quest rewards cannot be identified.

Module Version: v0.23

Mystified items added to a quest rewards cannot be identified. Quest log v0.5.1

To Reproduce
Steps to reproduce the behavior:

  1. Mystify an item
  2. Add to quest rewards
  3. Attempt to reveal and nothing happens

Foundry Version:
0.7.6

Game System:
Pathfinder 2e 1.10.15.2210

Minor visual error when used alongside another module.

Hey, your module has been super convenient for making unidentified items a bit less tedious. So thanks for that!

Recently, Tidy5e Sheet had a visual overhaul and now causes a minor visual issue when used with Unidentified Items, namely the "Mechanics / Flavor Text" text gets doubled, as seen in this screenshot:

screenshott

It's not too big a deal and easily ignored, but I figured I might as well ask if it's just as easy to fix. I also added an issue to Tidy5eSheet's github, so it might get fixed from the other end.

Best regards.

Some ideas for improvements

Thx for the module, Forien. It's great!

Some ideas that came into my mind, when I was playing around with it.

  1. Would be great if you can configure options in the module setting menu like:
  • Keep original image of the item
  • Set item type or even category as default name. So a Lightning Sword of Xorhash will be just a Sword
  • a) Duplicate the item (like it is right now) OR b) Don't duplicate it (delete the original item) if thats possible. Or just create a new unidentified item and when it is identified replace it by the linked original item.
  1. As many of us using loot sheet characters. Would be great if you can do the mystify right from a character not only from the sidebar item menu

PF2E- Track identification attempts/DCs

In PF2E, a PC can try to identify an item once per 24h. Would be nice if there was an easy way to track that. Also, it would be nice if there way a field where we can put what skills are required to ID the item and what the DC is. As a workaround, I use GM notes to track that information.

Thanks!

[BUG] Mistify (advanced) not working

Module Version: v0.2.3
Foundry Version v0.7.5

Describe the bug
Right click on item -> Mystify (advanced) -> Mystify
Nothing happens and error is logged.
image

Right click on item -> Mystify (advanced) -> Replace
Item is mistified (as i understand), but icon and name stays the same.

Browser:

  • Google Chrome

Game System:

  • D&D5e

Additional context
As I understood, there is an issue parsing formdata from advanced mistify page.
let formData = validateForm(form); (

let formData = validateForm(form);
)
validateForm not only is declared deprecated since 0.7.0, but also returns parsed data wrapped in special object, which must be additionaly converted to usable structure (value aren't accessible without it. somehow)
let formData = new FormDataExtended(form).toObject();
seems to do the trick: no more deprecation and form values are converted to usable form, so name, image url and other fields are here now.

Use the item while it is mystified

My players have potions that they would like to consume even though they don't know what it does. Is it possible for them to use scrolls/items without them needing to identify it?

0.8.x Compatibility

Currently, this module appears to not function at all in Foundry 0.8. I just wanted to see if you were planning on updating it.

Allow players with the Identify spell to identify items

The request is fairly simple in nature. If the player has the identify spell, they gain the option to identify the item. Further refinements could be an interference that requires the player to choose if they are using a spell slot or casting as a ritual, then the GM would approve/deny the identification request.

[BUG] Triggers renderItemSheet5e hook twice

Module Version: v0.2.3

Describe the bug
With the module enabled, there are two calls to the renderItemSheet5e Hook which causes magicitems (for instance) to error out due broken data in the forms (see https://gitlab.com/riccisi/foundryvtt-magic-items/-/blob/master/module/magicitems.js#L17 for where magicitems sets itself up).

It also looks like it might be breaking item quantities (see https://discordapp.com/channels/170995199584108546/742801483795529778/749657740963610725 for reference).

To Reproduce
Steps to reproduce the behavior:

  1. Have a module with:
Hooks.on(`renderItemSheet5e`, (app, html, data) => {
    debugger;
});
  1. See that it gets fired twice.
  2. Alternatively, put a breakpoint on line 17 in magicitems.js

Expected behavior
Expect the Hook to only be called once.

Browser:

Foundry Version:
0.7.1

Game System:
DnD5e 0.96

** Modules Installed:**

Doesnt work anymore in V11 Foundry. [BUG]

Module Version: v0.2.3

Describe the bug
You can not edit Items at last.

**Foundry Version:**11.309

Game System: DnD5e

Is it possible to update the module? Would pay for it. Its the only one, who offers a perfect solution to identify items.

[BUG]

Module Version: v0.1.4

Describe the bug
In PF2e you can't mystify an item from an actor sheet. Works only in the sidebar itself.

Thats the Error msg when you hit mystify on an actors item:
Identification.js:13 Uncaught (in promise) TypeError: Cannot read property 'type' of null
at Function.mystify (Identification.js:13)
at Object.onclick (init.mjs:72)
at HTMLAnchorElement. (foundry.js:3960)
at HTMLAnchorElement.dispatch (jquery.min.js:2)
at HTMLAnchorElement.v.handle (jquery.min.js:2)

Browser:
chrome

Foundry Version:
0.64

Game System:
PF2e

[BUG] 9.X unable to right-click on any item

Module Version: v0.3.17

Describe the bug
When you right click any item in the Item Directory the getFlag property crashes

image

To Reproduce
Steps to reproduce the behavior:

  1. Go to Item Directory
  2. Right-click
  3. Boom

Expected behavior
Should let us right-click

Foundry Version:
9.X

Game System:
5e

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.