forien / foundryvtt-forien-custom-fonts Goto Github PK

Module Version: v0.1.0

Describe the bug
Fonts do not render properly after reloading the page until the scene with text drawings is visited twice or the "Drawing Tools" button is clicked.

To Reproduce
Steps to reproduce the behavior:

1. Add some text drawings on a few scenes, set their fonts to the custom google fonts.
2. Reload the page in your browser (tested in Electron, Chrome and Firefox)
3. The fonts on the landing page look like Signika.
4. Switch to other Scene. The fonts on that scene also look like Signika.
5. Switch back to Scene 1. The fonts are now properly rendered as your custom google fonts.
6. Switch back to Scene 2. The fonts are now properly rendered as your custom google fonts.
7. Switch back to Scene 3. The fonts look like Signika.
8. Press "Drawing Tools" button. The fonts are now properly rendered as your custom google fonts.

Expected behavior
I kinda hoped it is possible to draw fonts properly for each scene whenever it is rendered. It would be weird to tell your players to switch scenes back and forth to render the proper fonts.

Browser:
Electron, Chrome, Firefox

Foundry Version:
0.6.5

Game System:
dnd5e 0.93

Additional context

I would love to be able to add some of my custom (paid) fonts somewhere in my Data folder so that I can use them for drawings and such. Seems like it's right up this module's alley.

please include license terms
(i.e. did you create these fonts, are the public use, can I use them in a video?)

Currently when requesting a font name that has been entered, it will only request the regular 400 weight version of the font from Google-Fonts. Which means if you try to use things like semi-bold or thin weights, they won't be loaded and shown properly.

It would be nice if there was a way of requesting the various weights etc. from Google-Fonts, so that things like proper semi-bold, thin, italic variations etc. of fonts can be used. From a quick check, it's done by appending the variations required after the font-name on the request, something like: family=Roboto:wght@100;300;400;500;700. Although it gets a bit more messy if you're wanting to request the italic variations as well.

Although my suggestion would likely mean a bit of a rework to the settings UI section to actually be usable, due to it becoming a bit of a mess trying to fit everything into a single text-box. Rather than having something like a table of fonts with a second column for the variations wanted. So it'd likely to be a pain to implement without some annoying extra stuff...

Thanks for the module either way, it's very handy! :)

Module Version 0.1.0
Foundry 0.6.5 standalone